851831 - generic_app double entering configman options

Status: RESOLVED FIXED

(Socorro :: Backend, task)

Description

[K Lars Lohn [:lars] [:klohn]]

in the generic_app.py there is a section:

    definitions = (
      app_definition,
      initial_app.get_required_config(),
      logging_required_config(app_name)
    )

the `initial_app.get_required_config(),` is not necessary and, in fact, double enters the configman entries.  Remove it.

Comment 1

[K Lars Lohn [:lars] [:klohn]]

rfw: do you recall why you added this line?  If I were to remove it, do you know off hand what would break?

Comment 2

[Tony Young [:rfw]]

:lars I don't believe I added that line, git blame points to https://github.com/mozilla/socorro/commit/8052687ba0141d407863c210b8df9eab58256518

Comment 3

[[DEACTIVATED] Adrian Gaudebert]

I added that because the setup_db app was broken at the time. Maybe that's fixed in configman now, but if you remove it please test that setup_db still works.

Comment 4

[K Lars Lohn [:lars] [:klohn]]

adrian - I'm unable to reproduce the problem that originally prompted you to make this change.  As far as I can tell, this change breaks all configman apps including setupdb_app.

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/fb3866dda52ceb6ff8e83cf0a8e16dd1877ad34f
Merge pull request #1154 from twobraids/double_options

fixes Bug 851831- removes doubling of configman options