851834 - Remove nsISupportsArray from layout/xul/tree

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Alex Vincent [:WeirdAl]]

This should be simple enough.  I'm starting with a conversion to nsCOMArray<nsIAtom>, though I may go further.

Comment 1

[Alex Vincent [:WeirdAl]]

Attachment: patch

This patch is untested aside from compiling.  I'll test it later tonight.

Comment 2

[Alex Vincent [:WeirdAl]]

Comment on attachment 725896 [details] [diff] [review]
patch

Tested now and it works.

Comment 3

[[e-mail]]

Comment on attachment 725896 [details] [diff] [review]
patch

>-    int32_t index;
>-    mScratchArray->GetIndexOf(curr->mAtom, &index);
>+    int32_t index = mScratchArray.IndexOf(curr->mAtom);
>     if (index == -1) {
.Contains()

Maybe this should really be a Set, not an Array... I'm not sure whether the overhead justifies it though.

>-    nsCOMPtr<nsIAtom> pseudo = do_QueryElementAt(aInputWord, i);
>+    nsIAtom* pseudo = aInputWord[i];
>     nsTransitionKey key(currState->GetStateID(), pseudo);
Just inline this, it's not used anywhere else.

>+typedef nsCOMArray<nsIAtom> AtomArray;
[I wasn't convinced but it turns out you're not the first to do this!]

Comment 4

[Alex Vincent [:WeirdAl]]

Attachment: patch with r+

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d2e25c5011e

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9d2e25c5011e