851859 - debug builds on ppc64 abort at runtime with "Compile-time page size does not divide the runtime one."

Status: RESOLVED FIXED

(Core :: Memory Allocator, defect)

Description

[Steve Singer (:stevensn)]

Debug builds on ppc64 are giving me runtime aborts with "Compile-time page size does not divide the runtime one."

On PPC64 sysconf reports _SC_PAGESIZE as 65536

Comment 1

[Steve Singer (:stevensn)]

Attachment: adjust the static pagesizes based on the architecture

This patch will use a different pagesize as required.  These values are based on what is being done in HeapAPI.h

Comment 2

[Justin Lebar (not reading bugmail)]

Comment on attachment 725837 [details] [diff] [review]
adjust the static pagesizes based on the architecture

Thanks for your patch!

r=me, but could you please add a comment indicating where you copied these ifdefs from?

Also, this is a nit, but we usually format checkin comments as

  Bug XXX - Starting with capital letter

or

  But XXX: Starting with capital letter

Something like

  Bug 851859 - Set jemalloc's page size based on the architecture instead of assuming it's always 4kb, r=jlebar

would be good.

Another nit that doesn't matter here is that we always attach -U8 patches.

If you don't mind attaching another patch here we can get this into the tree for you.

Comment 3

[Steve Singer (:stevensn)]

Attachment: updated patch: adjust the static pagesizes based on the architecture

Here is an updated patch in -u8 format with improved comments

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cbc545c94cea

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cbc545c94cea

Comment 6

[Marty Rosenberg [:mjrosenb]]

Hey, I just stumbled onto this, and unfortunately, the page size on ppc64 isn't fixed.  There is a kernel config that can set the page size to 4k or 64k at compile time.

Comment 7

[Mike Hommey [:glandium]]

(In reply to Marty Rosenberg [:mjrosenb] from comment #6)
> Hey, I just stumbled onto this, and unfortunately, the page size on ppc64
> isn't fixed.  There is a kernel config that can set the page size to 4k or
> 64k at compile time.

I noted that in another bug, but i can't find it.