debug builds on ppc64 abort at runtime with "Compile-time page size does not divide the runtime one."

RESOLVED FIXED in mozilla22

Status

()

Core
Memory Allocator
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: stevensn, Assigned: stevensn)

Tracking

21 Branch
mozilla22
PowerPC
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Debug builds on ppc64 are giving me runtime aborts with "Compile-time page size does not divide the runtime one."

On PPC64 sysconf reports _SC_PAGESIZE as 65536
(Assignee)

Comment 1

5 years ago
Created attachment 725837 [details] [diff] [review]
adjust the static pagesizes based on the architecture

This patch will use a different pagesize as required.  These values are based on what is being done in HeapAPI.h
(Assignee)

Updated

5 years ago
Attachment #725837 - Flags: review?(justin.lebar+bug)
Comment on attachment 725837 [details] [diff] [review]
adjust the static pagesizes based on the architecture

Thanks for your patch!

r=me, but could you please add a comment indicating where you copied these ifdefs from?

Also, this is a nit, but we usually format checkin comments as

  Bug XXX - Starting with capital letter

or

  But XXX: Starting with capital letter

Something like

  Bug 851859 - Set jemalloc's page size based on the architecture instead of assuming it's always 4kb, r=jlebar

would be good.

Another nit that doesn't matter here is that we always attach -U8 patches.

If you don't mind attaching another patch here we can get this into the tree for you.
Attachment #725837 - Flags: review?(justin.lebar+bug) → review+
(Assignee)

Comment 3

5 years ago
Created attachment 725983 [details] [diff] [review]
updated patch: adjust the static pagesizes based on the architecture

Here is an updated patch in -u8 format with improved comments
Attachment #725837 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #725983 - Flags: checkin?
Attachment #725983 - Flags: checkin?
https://hg.mozilla.org/mozilla-central/rev/cbc545c94cea
Status: UNCONFIRMED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Hey, I just stumbled onto this, and unfortunately, the page size on ppc64 isn't fixed.  There is a kernel config that can set the page size to 4k or 64k at compile time.
(In reply to Marty Rosenberg [:mjrosenb] from comment #6)
> Hey, I just stumbled onto this, and unfortunately, the page size on ppc64
> isn't fixed.  There is a kernel config that can set the page size to 4k or
> 64k at compile time.

I noted that in another bug, but i can't find it.
You need to log in before you can comment on or make changes to this bug.