851981 - mozalloc_oom.cpp:41:53: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Daniel Holbert [:dholbert]]

Recently-introduced build warning:
{
/mozilla/memory/mozalloc/mozalloc_oom.cpp: In function 'void mozalloc_handle_oom(size_t)':
/mozilla/memory/mozalloc/mozalloc_oom.cpp:41:53: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
}

This is from got a signed int loop-iterator "i" that's compared against the size_t value OOM_MSG_FIRST_DIGIT_OFFSET.

We probably just want to make "i" a size_t as well (and static-assert that OOM_MSG_FIRST_DIGIT_OFFSET is greater than 0, so that the "i >= OOM_MSG_FIRST_DIGIT_OFFSET" comparison will eventually fail).

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Benjamin Smedberg]

Comment on attachment 725955 [details] [diff] [review]
fix

I don't think you meant to reindent the modeline, right? r=me with that reverted

Comment 3

[Daniel Holbert [:dholbert]]

Oops -- thanks for catching that. :)

Fixed that & pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/8696e0523772

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8696e0523772