851982 - Assertion failure in nsUnicharStreamLoader::WriteSegmentFun with ISO-2022-JP (#2)

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Assertion failure: ((bool)(__builtin_expect(!!(!NS_FAILED_impl(rv)), 1))), at netwerk/base/src/nsUnicharStreamLoader.cpp:218

Same assertion as bug 843434, which Josh fixed last week.

Comment 1

[Masatoshi Kimura [:emk]]

mErrBehavior check is needed here, too.
https://mxr.mozilla.org/mozilla-central/source/intl/uconv/ucvja/nsJapaneseToUnicode.cpp#506
And we should audit the all occurrence of |goto error2;|.

Comment 3

[Carsten Book [:Tomcat]]

also this is happing on realworld sites see my bug 883083

Comment 4

[Patrick McManus [:mcmanus]]

:emk or josh, can you supply a patch here?

Comment 5

[Masatoshi Kimura [:emk]]

Attachment: Make ISO-2022-JP decoder reliable

Comment 6

[Masatoshi Kimura [:emk]]

Attachment: Regression test

Comment 7

[Masatoshi Kimura [:emk]]

Although the assertions are debug only, this change is web-visible because of TextDecoder. The test should catch all possible cases.

I commented out |SimpleTest.expectAssertions(0, 2);| line because testharness doesn't define SimpleTest.

Comment 8

[Masatoshi Kimura [:emk]]

https://tbpl.mozilla.org/?tree=Try&rev=11e9dbc16257

Comment 9

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/84855cdd91da
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1d09117491f

Comment 10

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/mozilla-central/rev/84855cdd91da
https://hg.mozilla.org/mozilla-central/rev/d1d09117491f

Comment 11

[Jesse Ruderman]

> I commented out |SimpleTest.expectAssertions(0, 2);| line because testharness 
> doesn't define SimpleTest.

Which test harness does this test run in?

Comment 12

[Masatoshi Kimura [:emk]]

dom/encoding/test/test_TextDecoder.html.

Comment 13

[Al Billings [:abillings - ex-MoCo]]

Was this bug present in Firefox 23 or earlier?

Comment 14

[Masatoshi Kimura [:emk]]

Probably Firefox 20 or later. This is a regression from bug 638379.