852024 - [TSF] MetroWidget hasn't implemented GetIMEUpdatePreference()

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

MetroWidget doesn't implemented nsIWidget::GetIMEUpdatePreference(). This causes nsIMEStateManager doesn't create nsTextStateManager. Then, neither NotifyIME(NOTIFICATION_OF_FOCUS), NotifyIME(NOTIFICATION_OF_BLUR), NotifyIME(NOTIFICATION_OF_SELECTIONCHANGE) nor NotifyIME(NOTIFICATION_OF_FOCUS) is called.

By this bug, nsTextStore never resets cached selection. Therefore, for example, if you try to input "Metro" without TIP and "アプリ" with TIP, then, the "ア" is inserted before "M" because nsTextStore thinks the caret position still stays before "M".

The behavior may be a regression of bug 790516.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Thank you for your quick review!
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e115ca28105

Comment 2

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5e115ca28105