Closed Bug 852046 Opened 7 years ago Closed 7 years ago

"Close Tab" overlapping and unreadable

Categories

(Firefox for Metro Graveyard :: App Bar, defect)

x86_64
Windows 8.1
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 22

People

(Reporter: kjozwiak, Assigned: mbrubeck)

References

Details

(Keywords: regression, Whiteboard: p=1)

Attachments

(2 files)

Attached image overlapping "Close Tab"
When you take a look at the currently opened Tabs (Windows + Z), the "Close Tab" text is overlapping and is unreadable at times. Posted a screenshot to illustrate the issue.

Steps to reproduce the issue:

1) Launch Firefox Metro
2) Select Windows + Z and take a look at the "Close Tab"
3) Open a few new tabs and load several websites (you'll see that its unreadable sometimes depending the sites color scheme)
Whiteboard: p=1
Attached patch patchSplinter Review
I added a label to this button in bug 851156, for accessibility, but I didn't mean to make it visible.  We hide <toolbarbutton> labels by default but not <button> labels.  This patch hides the close-tab <button> label.
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Attachment #726257 - Flags: review?(jmathies)
Blocks: 851156
No longer blocks: metrov1triage
Keywords: regression
Attachment #726257 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/mozilla-central/rev/b10a9f0e0a76
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Went through the following issue using the latest Nightly build from the following location:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-03-20-03-11-03-mozilla-central/

- Opened several different tabs and made sure the "Close Tab" was not appearing
- Ensured that pressing the "X" on the tabs closed them without any issues
- Ensured that the start page loads when all the tabs have been closed using the "X"
- Pressed the "X" on the start page and made sure it re-opens the start page without issues
Status: RESOLVED → VERIFIED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.