Closed Bug 852107 Opened 8 years ago Closed 8 years ago
Monkey landing broke Windows desktop B2G builds
Not that I blame you for not knowing this seeing how they're hidden and all... https://tbpl.mozilla.org/php/getParsedLog.php?id=20772654&tree=Firefox b2g_mozilla-central_win32_gecko nightly on 2013-03-18 03:10:44 PDT for push b2636816c7fd slave: w64-ix-slave77 Library.obj jsperf.obj pm_stub.obj Creating library mozjs.lib and object mozjs.exp AsmJSLink.obj : error LNK2019: unresolved external symbol "class js::AsmJSModule & __cdecl js::AsmJSModuleObjectToModule(class JSObject *)" (?AsmJSModuleObjectToModule@js@@YAAAVAsmJSModule@1@PAVJSObject@@@Z) referenced in function "bool __cdecl DynamicallyLinkModule(struct JSContext *,class js::StackFrame *,class JS::Handle<class JSObject *>)" (?DynamicallyLinkModule@@YA_NPAUJSContext@@PAVStackFrame@js@@V?$Handle@PAVJSObject@@@JS@@@Z) mozjs.dll : fatal error LNK1120: 1 unresolved externals
Ah, ok, should be simple to fix.
I was able to repro this link error locally building --disable-ion. Could you verify that this cset: https://hg.mozilla.org/integration/mozilla-inbound/rev/7e13a94a3f3b Fixes Windows desktop B2G builds?
Unfortunately, those builds run on a nightly-only basis on m-c at the moment (soon to change, but not complete yet), so I won't know until after this hit's m-c. Putting [leave open] on the bug and I'll close it once I can confirm that it's fixed. Thanks for the quick patch!
Whiteboard: [leave open]
Looks good, thanks.
Assignee: general → luke
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.