852224 - SMS send activity should allow specifying the message's body

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Mounir Lamouri (:mounir)]

For the moment, the SMS send activity doesn't allow to specify the message's body for no apparent reason. We should fix that because most third party apps that will try to use this activity will try to specify a message.

Comment 1

[mayayo]

 function showThreadFromSystemMessage(number, body) seems to be handling this body and setting to MessageManager only when number is not present.

Comment 2

[Rick Waldron [:rwaldron]]

ActivityHandler.showThreadFromSystemMessage(message) now accepts a complete message object, which includes all of the message object properties.

Regardless, it should be trivial to upgrade the send activity to include "body".

Comment 3

[Borja Salguero [:borjasalguero]]

I think this is currently implemented here https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/js/activity_handler.js#L45. Mounir, Do you mean that we need any extra feature here? Thanks!

Comment 4

[Rick Waldron [:rwaldron]]

Borja, it's not enough to just point at an alias binding. Someone needs to test that sending an object with a "body" property does what is expected.

Comment 5

[Rick Waldron [:rwaldron]]

Attachment: screen shot

new MozActivity({
  name: 'new',
  data: {
    type: 'websms/sms',
    number: '999',
    body: 'hi!'
  }
});


See attachment