[MP] Change - Re-enable localization of Metro Firefox

VERIFIED FIXED in Firefox 26

Status

defect
P2
major
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Tracking

({intl})

Trunk
Firefox 26
All
Windows 8.1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [preview] feature=change c=tbd u=tbd p=1)

Attachments

(1 attachment)

Assignee

Description

6 years ago
Once the strings in /browser/metro are reviewed and stable, we should back out bug 844068 and let localization of the Metro UI begin.

We've just finished reviewing our strings, and have finished nearly all of our planned string changes.  The only planned change I'm aware of to existing strings is replacing the download manager with a download bar (bug 831942).  We should probably wait for that change to land, then turn localization back on.  (Of course we will continue to add new strings as we add features, and existing strings might occasionally change here or there, but hopefully no more than in other parts of mozilla-central.)

Note to localizers: We disabled the Metro UI on for Aurora 21, and plan to disable it again for Aurora 22.  We will not enable Metro Firefox on our release branches until its feature-completeness and quality are at the appropriate level for each branch.  I'll make sure the l10n community is aware as early as possible of any plans to enable Metro on Aurora or any additional branches.  I'll also try to prioritize changes like bug 831942 so that we can turn on localization as soon as possible and give you as much time as possible to start translating strings on mozilla-central.
Blocks: 852263
(In reply to Matt Brubeck (:mbrubeck) from comment #0)
> Of course we will continue to add new strings as we
> add features, and existing strings might occasionally change here or there,
> but hopefully no more than in other parts of mozilla-central.)

That's supposed to happen. Just keep in mind that, once a string has landed on mozilla-central, if you want to change it you need to use a new ID for that entity, unless you're just fixing a typo or similar.

> I'll also try to prioritize changes like bug 831942 so
> that we can turn on localization as soon as possible and give you as much
> time as possible to start translating strings on mozilla-central.

Thanks ;-)

The longer you leave Metro UI enabled on central, the easier is to catch problems before they move to Aurora and require to break the string freeze.


>We've just finished reviewing our strings, and have finished nearly all of our planned string changes.

Some of the questions I asked in bug 840888 are still unanswered. For example do you really need all those empty accesskeys in passwordmgr.properties?
Assignee

Updated

6 years ago
Depends on: 845484
I don't think we should switch on l10n of metro until we expect to switch it on in aurora.

The reason being is that for those teams working on central, the infrastructure on aurora is going to bitch about strings they should remove.
Assignee

Updated

6 years ago
Depends on: 854077
Also as long as we hard-code accesskeys in Metro localizers will not be able to localize the keyboard shortcuts as known in their locale for Firefox desktop. See bug 882074.
Depends on: 882074
Depends on: 886942
No longer depends on: 831942
No longer depends on: 886942
Depends on: 893066
No longer depends on: 893066
Depends on: 898477
Assignee

Comment 4

6 years ago
We expect to enable Metro Firefox in Aurora and Beta for Firefox 26 (or Firefox 27 if we miss that deadline for some reason).

I would like to re-enable localization on mozilla-central early in the Firefox 26 cycle (i.e. very soon).  I'll also prioritize bug 882074 and any other bugs that are important for localization.  Any comments/objections?
Assignee: nobody → mbrubeck
Blocks: metrov1it13, MetroPreviewRelease
No longer blocks: 852263
Status: NEW → ASSIGNED
No longer depends on: 898477
Priority: -- → P2
QA Contact: jbecerra
Summary: Re-enable localization of Metro Firefox → [MP] Change - Re-enable localization of Metro Firefox
Whiteboard: [preview] feature=change c=tbd u=tbd p=1
Assignee

Comment 5

6 years ago
Posted patch patchSplinter Review
Backs out bug 844068.
Attachment #790771 - Flags: review?(l10n)
Comment on attachment 790771 [details] [diff] [review]
patch

Review of attachment 790771 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good technically.

Asking flod for feedback on the content this will switch on, are there any unknown left overs?
Attachment #790771 - Flags: review?(l10n)
Attachment #790771 - Flags: review+
Attachment #790771 - Flags: feedback?(francesco.lodolo)
Comment on attachment 790771 [details] [diff] [review]
patch

Review of attachment 790771 [details] [diff] [review]:
-----------------------------------------------------------------

The only one that I'm aware of is bug 882074, but it's almost fixed.
Attachment #790771 - Flags: feedback?(francesco.lodolo) → feedback+
Assignee

Comment 8

6 years ago
Thanks!  Looking forward to more feedback from the l10n community once this is on central and later aurora.
https://hg.mozilla.org/integration/fx-team/rev/7c4e4b3afb0d
https://hg.mozilla.org/mozilla-central/rev/7c4e4b3afb0d
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Could anyone please give any guidelines that can help the QA in verifying this issue? Thanks!
Flags: needinfo?
Flags: needinfo? → needinfo?(mbrubeck)
Assignee

Comment 11

6 years ago
(In reply to Manuela Muntean [:Manuela] [QA] from comment #10)
> Could anyone please give any guidelines that can help the QA in verifying
> this issue? Thanks!

This change mainly affects localizers; it is not visible in the English-language build.  Depending on whether any localizers have finished translating Metro strings on mozilla-central, you may be able to test their work using the builds here (perhaps the ".it" build?):

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-central-l10n/
Flags: needinfo?(mbrubeck)
"it" is completely localized, usually updated with missing strings in 24/48 hours, so it's definitely good for testing. De, fr and es-ES are generally in good shape too.
Verified as fixed for iteration #14, with the "it" build from: ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013/09/2013-09-18-03-02-02-mozilla-central-l10n/ , build ID: 20130918030202.

Italian Metro seems to work properly.
Status: RESOLVED → VERIFIED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.