85229 - remove image map button doesn't update properly

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[Kathleen :Brade]

The button to remove the image map in the image properties dialog doesn't update 
properly.  If I use the advanced edit dialog to add an image map, the remove 
button doesn't enable.  The button should always be enabled no matter how I add 
an image map (via image map editor or via advanced edit).

Comment 1

[rubydoo123]

cmanske

Comment 2

[Charles Manske]

changing milestone to 0.9.4

Comment 3

[Charles Manske]

Attachment: Fix: Move code to check for image map into InitDialog() method, which is caleld after using Advanced Edit

Comment 4

[Charles Manske]

Attachment: Updated patch to move code to get image map into its own function.

Comment 5

[Charles Manske]

Attachment: Updated patch: more cleanup of GetImageMap() method (simplify, remove warnings)

Comment 6

[Charles Manske]

Attachment: Update: More fixup - allow removing imagemap attribute if "usemap" exists, even if mapcollection doesn't

Comment 7

[Kathleen :Brade]

r=brade

Comment 8

[Charles Manske]

Attachment: Update: Restored assignment to "imageMap" variable; fixed removeImageMap() to work even if map doesn't exist

Comment 9

[Charles Manske]

There are still problems with image map logic, now covered by bug 94749,
but with latest patch, Remove button does the right thing and its enable state
is updated correctly.

Comment 10

[Kathleen :Brade]

r=brade

Comment 11

[Joe Hewitt (gone)]

sr=hewitt

Comment 12

[Charles Manske]

checked in

Comment 13

[sujay]

Dan/Brian, can one of you verify this is fixed since you are the image map
experts? thanks...

Comment 14

[Kathleen :Brade]

Sujay--you should be able to verify this yourself
 * Use the Advanced Edit dialog (from the image dialog) to add an image map to 
the image
 * Check if the button is enabled or not when you return to the image properties 
dialog

Try both adding and removal.

Comment 15

[Charles Manske]

Sujay: I emailed you a test page, didn't I?
I'll attach it here.

Comment 16

[Charles Manske]

Attachment: Test page for image map

Comment 17

[James Baxter]

Verified with test page on 9-03 build