852296 - moznetwork should have documentation

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[William Lachance (:wlach)]

Let's add documentation for moznetwork. It would be useful.

Comment 1

[William Lachance (:wlach)]

Attachment: Add documentation for moznetwork

Some simple documentation for moznetwork

Comment 2

[William Lachance (:wlach)]

(In reply to William Lachance (:wlach) from comment #1)
> Created attachment 726347 [details] [diff] [review]
> Add documentation for moznetwork
> 
> Some simple documentation for moznetwork

BTW, yes, the reviewer field in the subject is wrong. I was going to assign to :jhammel initially, but decided to assign to :mcote at the last minute because I thought moznetwork might be useful in autophone and thought a quick review would be a good excuse to learn about it. :)

Comment 3

[Mark Côté [:mcote]]

Comment on attachment 726347 [details] [diff] [review]
Add documentation for moznetwork

Review of attachment 726347 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, though I see you've already pushed it with r=mcote...

Comment 4

[William Lachance (:wlach)]

(In reply to Mark Côté ( :mcote ) from comment #3)
> Comment on attachment 726347 [details] [diff] [review]
> Add documentation for moznetwork
> 
> Review of attachment 726347 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good, though I see you've already pushed it with r=mcote...

Yeah, oops. This was sitting on master when I pushed up something else. Guess I should get back into the habit of creating branches for each bug...

Comment 5

[William Lachance (:wlach)]

Here's the push, for the record: https://github.com/mozilla/mozbase/commit/98003d3a30965a00046c537026b6c80abe256f27