852387 - [OPEN_][SMS]It can not return message list when view message through status bar.(617002074904)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Firefox_Mozilla]

Steps to reproduce:
1.lock screen and send a message to firefox phone;
2.unlock screen and drop down status bar to view this message;
3.tap back button.
Expected results:
1.return message list.
Actual results:
1.tapping back button is invalid.
2.this does not happen every time, but it has a high probability.

Comment 1

[Firefox_Mozilla]

mozilla build id：20130310070203

Comment 2

[Michael Vines [:m1] [:evilmachines]]

Sorry, what does "tapping back button is invalid." mean?

Comment 3

[Daniel Coloma:dcoloma]

> 2.this does not happen every time, but it has a high probability.

... and can you provide more details about the conditions when it happens? Specific numbers? Any open app? 

Additionally, build info is also helpful.

I've tried to repro with latest v1.0.1 and I have not managed to do so.

Comment 4

[Firefox_Mozilla]

build ID could see in Comment 1.
It is not related to number. It maybe happen when we insert USB cable to use mass storage first. And it only happens when receiving message in status of lock screen and view this message through dropping down status bar.

Comment 5

[Firefox_Mozilla]

(In reply to Michael Vines [:m1] [:evilmachines] from comment #2)
> Sorry, what does "tapping back button is invalid." mean?

Yes, it means "tapping back button is invalid."

Comment 6

[Daniel Coloma:dcoloma]

(In reply to Firefox_Mozilla from comment #4)
> build ID could see in Comment 1.
> It is not related to number. It maybe happen when we insert USB cable to use
> mass storage first. And it only happens when receiving message in status of
> lock screen and view this message through dropping down status bar.

I've tried multiple combinations: Receive the SMS with the lock screen without passcode, with a passcode, with mass storage enabled, disabled and I have not managed to reproduce it...

qawanted to check if QA can reproduce this.

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I reproduced this.  You have to have the SMS app closed: https://www.youtube.com/watch?v=CgBTLvSjSkw

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/778da49486f0
Gaia   6c3767c2dea43b5e9aff7d156d36d69649005621
BuildID 20130320070206
Version 18.0

STR: 
1. make sure SMS app is closed, ie long tap home, close SMS app
2. tap power button to put phone to sleep
3. send a SMS to the phone
4. unlock the screen
5. pull down the notification bar
6. tap on the messge
7. tap the back button

See video for actual result.

Comment 8

[Daniel Coloma:dcoloma]

Thanks! I have managed to reproduce it following your STR. Borja, can you have a look?

Comment 9

[Borja Salguero [:borjasalguero]]

Im gonna take a look on it.

Comment 10

[Michael Vines [:m1] [:evilmachines]]

(tef+, a pretty bad UI fail.)

Comment 11

[Borja Salguero [:borjasalguero]]

Hi all, I've tested with master & eng. Build and it's working as expected. Im gonna take a look about why it's failing in v1.0.1...

Comment 12

[Borja Salguero [:borjasalguero]]

It seems to be related with having the device locked. Im gonna investigate this issue. Thanks for your info.

Comment 13

[Andrew Overholt [:overholt]]

(In reply to Borja Salguero [:borjasalguero] from comment #12)
> It seems to be related with having the device locked. Im gonna investigate
> this issue. Thanks for your info.

Since Borja's looking at this I'll assign to him.

Comment 14

[Joe Cheng [:jcheng] (please needinfo)]

wonder where we are with this bug? thanks

Comment 15

[Fernando Campo (:fcampo)]

Finally discovered the reason for the bug, working on the fix (hopefully later today)

(In reply to Joe Cheng [:jcheng] from comment #14)
> wonder where we are with this bug? thanks

Comment 16

[Fernando Campo (:fcampo)]

Attachment: Link to PR https://github.com/mozilla-b2g/gaia/pull/9005

Comment 18

[Borja Salguero [:borjasalguero]]

Comment on attachment 733803 [details]
Link to PR https://github.com/mozilla-b2g/gaia/pull/9005

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Regression. Due to a patch landend long time ago this feature was broken.
User impact if declined: It's impossible to access to a SMS from notification bar when receiving the SMS in lockscreen (80% of the cases)
Testing completed: 
Risk to taking this patch (and alternatives if risky): Low. This is TEF+ and the patch is surgical.
String or UUID changes made by this patch:

Comment 19

[Borja Salguero [:borjasalguero]]

Comment on attachment 733803 [details]
Link to PR https://github.com/mozilla-b2g/gaia/pull/9005

Removing approval due to it's TEF+

Comment 20

[amiller]

This issue appears fixed on the Unagi build ID: 20130410070209
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/423f7851bdb5
Gaia: c614b3f3c956dc1e1adf93cf4cf41511ce75de80

also, issue appears fixed on  Unagi build ID: 20130410070204
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/935ff9a97f7b
Gaia: aff876b051c51d091cecf322b90c4f0093281b5e

After tapping the back button the user is returned back to the message list.

Comment 21

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train and v1.0.1.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train and v1.0.1, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 387da28fb7888a192000705cfc3a5dfa0a044c4c
  <RESOLVE MERGE CONFLICTS>
  git commit
  git checkout v1.0.1
  git cherry-pick -x $(git log -n1 v1-train)

Comment 22

[Fernando Campo (:fcampo)]

v1-train: blocked by uplift of bug 854413

Comment 23

[Julien Wajsberg [:julienw]]

You'll need to redo the patch for v1.0.1 anyway so I guess this could also land without bug 854413. (But I'd prefer to have 854413 too).

Comment 24

[Fernando Campo (:fcampo)]

Yup, finally changed the patch to merge it

v1-train: https://github.com/mozilla-b2g/gaia/commit/c27766126dc98de57c00f7aa20615769122ee40f
v1.0.1: https://github.com/mozilla-b2g/gaia/commit/1ab4c9b62ddb83a2315d1842c8660c20a8e62768

Anyway I'd like :jhford to check if everything is correct before change flags to fixed

Comment 25

[Julien Wajsberg [:julienw]]

I'm pretty sure John can't check better than you :-) If you checked on your device that it works properly, you can just flag as fixed already.

(and now I'm worried that uplifting 854413 will be difficult :( )

Comment 26

[Fernando Campo (:fcampo)]

(In reply to Julien Wajsberg [:julienw] from comment #25)
> I'm pretty sure John can't check better than you :-) If you checked on your
> device that it works properly, you can just flag as fixed already.

Oh, I didn't mean functionality, but checking if I crashed something on the branch...I usually am...let's say that I'm quite prone to make things explode without apparent reason :p

> (and now I'm worried that uplifting 854413 will be difficult :( )

Comment 27

[John Ford [:jhford] CET/CEST Berlin Time]

I agree with Julien, you're the best person to check the content of the patch!  Sounds like this bug should be set to fixed on branches.  If this is not true, please set the back.