852499 - Port Bug 835730 (Properly tear down components when the profile is being shut down) to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Startup & Profiles, defect)

Description

[Philip Chee]

From Bug 835730:

> nsBrowserGlue.js currently listens to xpcom-shutdown for part of its 
> cleanup, this should be done instead after a profile-before-change event, 
> additionally the places shutdown code does not respond properly to profile-
> before-change events causing problems in some unit tests (see bug 820438).

> The patch removes the xpcom-shutdown hook and responds to profile-before-
> change instead and it also resolves the problem with places shutdown seen
> in bug 820438.

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Port changes from Firefox.

Also implements Bug 836789 (Use weak references when adding observers in nsBrowserGlue.js). I hope I did it correctly.

Comment 2

[Philip Chee]

Comment on attachment 727690 [details] [diff] [review]
Patch v1.0 Port changes from Firefox.

I've had it baking for some time and I haven't noticed any problems. changing f? to r?

Comment 3

[[e-mail]]

Comment on attachment 727690 [details] [diff] [review]
Patch v1.0 Port changes from Firefox.

>   _onProfileShutdown: function()
>   {
>-    this._shutdownPlaces();
>-    if (!Sanitizer.doPendingSanitize())
>-      Services.prefs.setBoolPref("privacy.sanitize.didShutdownSanitize", true);
>+    // observer removal
>+    if (this._isIdleObserver)
>+      this._idleService.removeIdleObserver(this, BOOKMARKS_BACKUP_IDLE_TIME);
>+    this._isIdleObserver = false;
This is part of places, so should be part of shutdownPlaces... oh wait, it is. Or did you mean to move rather than copy?

>+
>+    UserAgentOverrides.uninit
();

>+  _onPlacesShutdown: function() {
>+    if (!Sanitizer.doPendingSanitize())
>+      Services.prefs.setBoolPref("privacy.sanitize.didShutdownSanitize", true);
Previously sanitise happened after places shutdownPlaces...

Comment 4

[Philip Chee]

Attachment: Patch v1.1 fix review issues. [check-in comment 5]

>>   _onProfileShutdown: function()
>>   {
>>-    this._shutdownPlaces();
>>-    if (!Sanitizer.doPendingSanitize())
>>-      Services.prefs.setBoolPref("privacy.sanitize.didShutdownSanitize", true);
>>+    // observer removal
>>+    if (this._isIdleObserver)
>>+      this._idleService.removeIdleObserver(this, BOOKMARKS_BACKUP_IDLE_TIME);
>>+    this._isIdleObserver = false;
> This is part of places, so should be part of shutdownPlaces... oh wait, it is. Or did you mean to move rather than copy?
Yes, it should be moved instead of copied.

>>+
>>+    UserAgentOverrides.uninit
> ();
Fixed.

>>+  _onPlacesShutdown: function() {
>>+    if (!Sanitizer.doPendingSanitize())
>>+      Services.prefs.setBoolPref("privacy.sanitize.didShutdownSanitize", true);
> Previously sanitise happened after places shutdownPlaces..
Fixed. Although Firefox puts the call to the sanitizer at the begining of _onPlacesShutdown().

Comment 5

[Philip Chee]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/eddffcc75444