add a make target for the pgo profile tests that we run during build time for pgo opt

RESOLVED FIXED in mozilla22

Status

RESOLVED FIXED
6 years ago
10 months ago

People

(Reporter: jmaher, Assigned: jmaher)

Tracking

unspecified
mozilla22
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
oh we have yet another fun bug where during pgo builds we run profileserver.  Luckily this is easier and I have verified on tryserver that a fix works.
(Assignee)

Comment 1

6 years ago
Created attachment 726629 [details] [diff] [review]
add a make target for pgo-profile-run
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #726629 - Flags: review?(ted)
Comment on attachment 726629 [details] [diff] [review]
add a make target for pgo-profile-run

Review of attachment 726629 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/testsuite-targets.mk
@@ +372,5 @@
>  leaktest:
>  	$(PYTHON) _leaktest/leaktest.py $(LEAKTEST_ARGS)
>  
> +pgo-profile-run:
> +	$(PYTHON) $(DEPTH)/_profile/pgo/profileserver.py

You should probably put an $(EXTRA_TEST_ARGS) at the end here so that we can support the "10" that the Linux mozconfigs want to pass:
http://mxr.mozilla.org/mozilla-central/source/browser/config/mozconfigs/linux32/release#12
Attachment #726629 - Flags: review?(ted) → review+
Component: Mozbase → Build Config
Product: Testing → Core
QA Contact: hskupin
https://hg.mozilla.org/mozilla-central/rev/bbd84dc53409
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
(Assignee)

Updated

6 years ago
Blocks: 852961

Updated

10 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.