Closed Bug 852509 Opened 9 years ago Closed 9 years ago

add a make target for the pgo profile tests that we run during build time for pgo opt

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla22

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

Attachments

(1 file)

oh we have yet another fun bug where during pgo builds we run profileserver.  Luckily this is easier and I have verified on tryserver that a fix works.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #726629 - Flags: review?(ted)
Comment on attachment 726629 [details] [diff] [review]
add a make target for pgo-profile-run

Review of attachment 726629 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/testsuite-targets.mk
@@ +372,5 @@
>  leaktest:
>  	$(PYTHON) _leaktest/leaktest.py $(LEAKTEST_ARGS)
>  
> +pgo-profile-run:
> +	$(PYTHON) $(DEPTH)/_profile/pgo/profileserver.py

You should probably put an $(EXTRA_TEST_ARGS) at the end here so that we can support the "10" that the Linux mozconfigs want to pass:
http://mxr.mozilla.org/mozilla-central/source/browser/config/mozconfigs/linux32/release#12
Attachment #726629 - Flags: review?(ted) → review+
Component: Mozbase → Build Config
Product: Testing → Core
QA Contact: hskupin
https://hg.mozilla.org/mozilla-central/rev/bbd84dc53409
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Blocks: 852961
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.