852530 - notificationBox is not visible on Linux

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Yury Delendik (:yury)]

The yellow notification box generated by pdf viewer is not visible. It's visible on Windows and MacOS.

"Unable to get a notification box for the fallback message" is visible in the console log. https://github.com/mozilla/pdf.js/blob/master/extensions/firefox/components/PdfStreamConverter.js#L404

Comment 1

[Yury Delendik (:yury)]

(It's actually the black notification box)

Comment 2

[Yury Delendik (:yury)]

Attachment: Fixes pdf.js notificationBox on Linux (for aurora)

https://tbpl.mozilla.org/?tree=Try&rev=0033b8864c2b

Comment 3

[Yury Delendik (:yury)]

Attachment: Fixes pdf.js notificationBox on Linux (for beta)

[Approval Request Comment]
Bug caused by (feature/regressing bug #): --
User impact if declined: Firefox/Linux users will not see any pdf viewer warnings/notifications
Testing completed (on m-c, etc.): pdf.js extensions and available on m-c (try server builds for beta http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-df1ddc8ddc1f/)
Risk to taking this patch (and alternatives if risky): low risk, affects only notification box logic
String or UUID changes made by this patch: --

Comment 4

[Yury Delendik (:yury)]

Comment on attachment 726775 [details] [diff] [review]
Fixes pdf.js notificationBox on Linux (for aurora)

[Approval Request Comment]
Bug caused by (feature/regressing bug #): --
User impact if declined: Firefox/Linux users will not see any pdf viewer warnings/notifications
Testing completed (on m-c, etc.): pdf.js extensions and available on m-c (try server builds for aurora http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-0033b8864c2b/)
Risk to taking this patch (and alternatives if risky): low risk, affects only notification box logic
String or UUID changes made by this patch: --

Comment 5

[bhavana bajaj [:bajaj]]

Comment on attachment 726775 [details] [diff] [review]
Fixes pdf.js notificationBox on Linux (for aurora)

low risk fix for the notification box to appear on linux.(fix is already on m-c as a part of :  https://bugzilla.mozilla.org/show_bug.cgi?id=852981 / #2969 Fixes notificationBox on Linux )

Adding qawanted,verifyme to help with verification here.

Comment 6

[u279076]

How does one force the notification bar to appear? Do we have a testcase?

Comment 7

[Yury Delendik (:yury)]

http://www.uscis.gov/files/form/n-400.pdf shall show the notification bar on all OSes.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7fb5d55e62df

Fixed on m-c by bug 852981.

Comment 9

[u279076]

Thanks Yury, adding this to our queue for verification.

Comment 10

[Bogdan Maris, Desktop QA]

Mozilla/5.0 (X11; Linux x86_64; rv:20.0) Gecko/20130319 Firefox/20.0

Tested on 21 beta 1 (buildID: 20130319110157).
The notification Box is now visible on Ubuntu 12.10 x64 and x32 but it`s colored in black. I think this should be yellow, that is the color that it was intended in the first place as shown on windows and mac. If this was intended the tracking flag status-firefox21 can be changed to verified.

Comment 11

[u279076]

Notification bars on Ubuntu have always been black AFAIK as part of their theming. Marking this verified based on your testing.

Comment 12

[Ada [:adalucinet]]

Mozilla/5.0 (X11; Linux x86_64; rv:22.0) Gecko/20100101 Firefox/22.0

Verified as fixed with FF 22 beta 1 (Build ID: 20130514181517) and Nightly 24.0a1 (Build ID: 20130515141643).