852598 - [B2G][FTE] During FTE cannot import Facebook contacts

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[mlevin]

Attachment: Cannot Import Facebook Contacts

Description:
During First Time Experience no contacts are imported after logging into Facebook.

Repro Steps:
1) Update manually to Unagi Build ID: 20130319070203
2) Go to Settings - Device Information - More Information - Reset Phone to initiate reset in order to start first time experience.
3) Go through the FTE up to the Import contacts page.
4) Tap Facebook
5) Enter Facebook credentials (username and password)

Expected:
After logging in the User should see a list of Facebook contacts to choose from for which ones wanted to import.

Actual:
User is taken back to FTE Import contacts page.

Repro frequency:
(2/2)

Environmental  Variables:
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/406b86b4b515
Gaia: c5a8b6476f0dbc456061227a7801e56634683eb0

Notes:
Windows Live AND Gmail also fail to import after logging in.

Test Suite Name: Smoketest
Q Analysts Test Team Priority Rating: (Pri 1)
See attached screenshot.

Comment 1

[Marcia Knous [:marcia]]

I just tried this using:

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/406b86b4b515
Gaia   c5a8b6476f0dbc456061227a7801e56634683eb0
BuildID 20130319070203
Version 18.0

and I wasn't able to reproduce using the Contacts app - is this only happen with First Time Experience?

Comment 2

[mlevin]

Yes, it is only happening in FTE.

Comment 3

[Maria Angeles Oteo (:oteo)]

I am also reproducing it but in V1.0.1, so I am nominating it for tef?

Comment 4

[Daniel Coloma:dcoloma]

Humm, I can reproduce it in v1.0.1 but not in v1-train. qawanted to check if this fails consistently in v1-train (It works for me with latest v1-train version)

Comment 5

[Cristian Rodriguez (:crdlc)]

umm maybe it works fine in other branches, but it is due to a race condition (with optimize lib) and IMHO it should be fixed in v1.0.1 and v1-train as well

Comment 6

[Daniel Coloma:dcoloma]

(In reply to Cristian Rodriguez de la Cruz (away til 03-21-2013) from comment #5)
> umm maybe it works fine in other branches, but it is due to a race condition
> (with optimize lib) and IMHO it should be fixed in v1.0.1 and v1-train as
> well

Yeah, if it is a race condition it makes sense it is not 100% reproducible.

Comment 7

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Comment 8

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/c27d6bab0ab2f1a97b046681e0e82cc5bb76126c

Comment 9

[Julien Wajsberg [:julienw]]

Daniel, about comment 4 > on v1-train, you need to build with GAIA_OPTIMIZE=1 to have optimized builds. |make dogfood| or [make production| on the Gaia code base set this automatically, but otherwise you have to set the env variable when launching the build.

In our releng builds, until very recently (yesterday or 2 days ago), this was only the case on engineering builds and not on user builds.

That's maybe why you don't see the problem there.

On v1.0.1 we optimize in all configurations.

Comment 10

[Julien Wajsberg [:julienw]]

Jose, are we sure your patch is enough ?

In my tests, I've seen some code trying to set the cancel handler (for example) and if this happens before init is executed, then it throws with "cancelButton is undefined".

also, regarding the title of the bug, I think this can happen in the Contacts app too, not only in FTE.

Comment 11

[Maria Angeles Oteo (:oteo)]

(In reply to Julien Wajsberg [:julienw] from comment #10)
> 
> also, regarding the title of the bug, I think this can happen in the
> Contacts app too, not only in FTE.

umm, I am only reproducing it in the FTE...
Julien, have you been able to reproduce it in Contact settings?

Comment 12

[Julien Wajsberg [:julienw]]

I'm really not sure about that, so if you don't reproduce then it's ok.
The current patch (if it fixes the bug) should handle both cases anyway.

Comment 13

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Removing QA wanted:
Happens in FTE Facebook Import for v1.1 as well as v1.0.1

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/778da49486f0
Gaia   6c3767c2dea43b5e9aff7d156d36d69649005621
BuildID 20130320070206
Version 18.0

v1.0.1:
"releases/mozilla-b2g18_v1_0_1" revision="fb7d33d358be"
"integration/gaia-1_0_1" revision="f342f58fce0e"

Comment 14

[Cristian Rodriguez (:crdlc)]

Hi Julien, I cannot reproduce this problem but if you detect some bug related to this one, please feel free to reopen the ticket and then I could revisit the patch. Thanks

Jose, did you detect some problem in Contacts app instead of FTE related to the curtain library?

Thanks for your help!

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit c27d6bab0ab2f1a97b046681e0e82cc5bb76126c as:
v1-train: 1ae77b5eafd34740497615b0f13ff9b1ab564a04
v1.0.1: 1a84001bea5cbd2fbda7fbffab0da2d941b43e77

Comment 16

[mlevin]

Verified fixed that importing Facebook contacts during FTE after a reset of the Unagi succeeds in importing those contacts.

Unagi used:
Unagi Build ID: 20130322070202
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/5aacf880400b
Gaia: 5a31a56b96a8fc559232d35dabf20411b9c2ca1d
RIL: Commercial