852600 - nsHTMLEditor does not traverse or unlink mStyleSheets

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Comment 1

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Attachment: traverse/unlink it

I noticed this while investigating incremental CC leaks.  Sadly this does not actually fix the leak. ;)

Comment 2

[(no longer active)]

(In reply to comment #1)
> Created attachment 726778 [details] [diff] [review]
>   --> https://bugzilla.mozilla.org/attachment.cgi?id=726778&action=edit
> traverse/unlink it
> 
> I noticed this while investigating incremental CC leaks.  Sadly this does not
> actually fix the leak. ;)

So what does?

Comment 3

[Andrew McCreight (out of office until 8/21) [:mccr8]]

> So what does?
Well, I basically rewrote the cycle collector in my local patch queue so it could be any number of things. ;)  Thanks for the review!

Comment 4

[(no longer active)]

(In reply to comment #3)
> > So what does?
> Well, I basically rewrote the cycle collector in my local patch queue so it
> could be any number of things. ;)

Is this the incremental CC stuff?

Comment 5

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Yup.  Right now it is leaking even when I'm not running it incrementally so something is pretty awry with my patches.

Comment 6

[Andrew McCreight (out of office until 8/21) [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/182c43d6c7d4

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/182c43d6c7d4