852667 - Sort out getAllocKind for generational GC

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: getInitialShape patch

I think we should get rid of all calls to this function. Minor GCs will still have to call something like it, but the correctness constraints will be a little looser.

This first patch changes getInitialShape so that we can pass numFixedSlots rather than the alloc kind.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: getAllocKind removal

This builds on top of some of Terrence's getAllocKind work. It removes all instances of getAllocKind.

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 726850 [details] [diff] [review]
getAllocKind removal

Review of attachment 726850 [details] [diff] [review]:
-----------------------------------------------------------------

Bill, you are my hero! After your email this morning I was going to go try to do this today myself. It's nice to know we're thinking along the same lines.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c4a29b7a2ead
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b3ba25df1af

Comment 4

[Joe Drew (not getting mail)]

https://hg.mozilla.org/mozilla-central/rev/c4a29b7a2ead
https://hg.mozilla.org/mozilla-central/rev/4b3ba25df1af