Closed Bug 852667 Opened 9 years ago Closed 9 years ago

Sort out getAllocKind for generational GC

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: billm, Assigned: billm)

References

Details

Attachments

(2 files)

I think we should get rid of all calls to this function. Minor GCs will still have to call something like it, but the correctness constraints will be a little looser.

This first patch changes getInitialShape so that we can pass numFixedSlots rather than the alloc kind.
Attachment #726846 - Flags: review?(bhackett1024)
This builds on top of some of Terrence's getAllocKind work. It removes all instances of getAllocKind.
Attachment #726850 - Flags: review?(terrence)
Attachment #726846 - Flags: review?(bhackett1024) → review+
Comment on attachment 726850 [details] [diff] [review]
getAllocKind removal

Review of attachment 726850 [details] [diff] [review]:
-----------------------------------------------------------------

Bill, you are my hero! After your email this morning I was going to go try to do this today myself. It's nice to know we're thinking along the same lines.
Attachment #726850 - Flags: review?(terrence) → review+
Blocks: 841059
https://hg.mozilla.org/mozilla-central/rev/c4a29b7a2ead
https://hg.mozilla.org/mozilla-central/rev/4b3ba25df1af
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Depends on: 856344
You need to log in before you can comment on or make changes to this bug.