Intermittent browser_pluginnotification.js | Test 20a, Should not have a click-to-play notification

RESOLVED FIXED in mozilla23

Status

()

Core
Plug-ins
P3
normal
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: RyanVM, Assigned: johns)

Tracking

({intermittent-failure})

Trunk
mozilla23
intermittent-failure
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=20815812&tree=Mozilla-Inbound

Rev3 WINNT 5.1 mozilla-inbound debug test mochitest-browser-chrome on 2013-03-19 00:20:48 PDT for push 9189484d54b7
slave: talos-r3-xp-039

00:28:22     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/browser_pluginnotification.js | Test 19a, Plugin should not be activated
00:28:22     INFO -  For application/x-test found plugin nptest.dll
00:28:22     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/browser_pluginnotification.js | Test 19b, Plugin should be activated
00:28:22     INFO -  ++DOMWINDOW == 44 (18E65E08) [serial = 1367] [outer = 164663A0]
00:28:23     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/browser_pluginnotification.js | Test 19c, Plugin should not be activated
00:28:23     INFO -  For application/x-test found plugin nptest.dll
00:28:23     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/browser_pluginnotification.js | Test 19d, Plugin should be activated
00:28:23     INFO -  ++DOMWINDOW == 45 (0D6AB030) [serial = 1368] [outer = 164663A0]
00:28:23     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/browser_pluginnotification.js | Test 19e, Plugin should not be activated
00:28:23     INFO -  For application/x-test found plugin nptest.dll
00:28:23     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/browser_pluginnotification.js | Test 19f, Plugin should be activated
00:28:23     INFO -  ++DOMWINDOW == 46 (07D065D0) [serial = 1369] [outer = 164663A0]
00:28:23  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_pluginnotification.js | Test 20a, Should not have a click-to-play notification
00:28:23     INFO -  Stack trace:
00:28:23     INFO -      JS frame :: chrome://mochitests/content/browser/browser/base/content/test/browser_pluginnotification.js :: test20a :: line 763
00:28:23     INFO -      JS frame :: chrome://mochikit/content/browser-test.js :: test_executeSoon/<.run :: line 522
00:28:23     INFO -      native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
David, Jared, do you have a first idea on what might be going on here?
Priority: -- → P3
OS: Windows XP → All
Hardware: x86 → All
Just because the notification is display:none doesn't mean that we won't have the click-to-play notification in the location bar. The attached binding should only affect the click-to-play overlay UI, right?

I'm not sure what caused this to start going orange, but maybe this check was questionable to begin with. It may have just been passing previously with timing luck.
Flags: needinfo?(dkeeler)
My understanding was that if a plugin was inside a div that was display:none, it wouldn't be instantiated (and thus there would be no click-to-play event that added the notification). It looks like this is incorrect. Taking out that check should have no effect on the correctness of that test, let's just go with that.
Flags: needinfo?(dkeeler)
(Assignee)

Comment 14

5 years ago
(In reply to David Keeler (:keeler) from comment #13)
> My understanding was that if a plugin was inside a div that was
> display:none, it wouldn't be instantiated (and thus there would be no
> click-to-play event that added the notification). It looks like this is
> incorrect. Taking out that check should have no effect on the correctness of
> that test, let's just go with that.

No, this should be correct. We somewhat broke it at one point, then fixed it in bug 784131... the day this intermittent started. Oh.

I'll see if I can find out what's going on here
Assignee: nobody → jschoenick
Status: NEW → ASSIGNED
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 26

5 years ago
It looks like this was fixed by bug 863792
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Depends on: 863792
Resolution: --- → FIXED
(Reporter)

Updated

4 years ago
Target Milestone: --- → mozilla23
Comment hidden (Treeherder Robot)
You need to log in before you can comment on or make changes to this bug.