852782 - update URL to final health report URL

Status: VERIFIED FIXED

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Description

[Mike Connor [:mconnor]]

Attachment: v1 - switch to final URL, start using urlFormatter

Per Laura and jakem, the final URL will be https://fhr.cdn.mozilla.net/%LOCALE%/index.html.  As we're adding the locale to the remote URL, we'll need to switch the places reading this pref to use urlFormatter instead.  This patch makes both changes, and should land once we have a placeholder on the CDN.  (Jake, Laura, is there a bug we can track for when we can land this?)

The patch itself is very simple, tests continue to pass.

Comment 1

[Matthew N. [:MattN]]

Comment on attachment 726982 [details] [diff] [review]
v1 - switch to final URL, start using urlFormatter

Review of attachment 726982 [details] [diff] [review]:
-----------------------------------------------------------------

r- because of the glossaryURL issue.

::: browser/base/content/abouthealthreport/abouthealth.js
@@ +33,4 @@
>      iframe.src = report.spec;
>      prefs.observe("uploadEnabled", this.updatePrefState, healthReportWrapper);
>    },
> +  

Nit: whitespace

@@ +76,1 @@
>      

ditto

::: services/healthreport/healthreport-prefs.js
@@ +22,4 @@
>  pref("datareporting.healthreport.service.loadDelayFirstRunMsec", 60000);
>  pref("datareporting.healthreport.service.providerCategories", "healthreport-js-provider");
>  
> +pref("datareporting.healthreport.about.reportUrl",   "https://fhr.cdn.mozilla.net/%LOCALE%/index.html");

Nit: Is the "index.html" part really necessary? We normally leave that part out.

@@ -22,4 @@
>  pref("datareporting.healthreport.service.loadDelayFirstRunMsec", 60000);
>  pref("datareporting.healthreport.service.providerCategories", "healthreport-js-provider");
>  
> -pref("datareporting.healthreport.about.glossaryUrl", "https://services.mozilla.com/healthreport/glossary.html");

It seems like this pref is still used in init of abouthealth.js

Comment 2

[Mike Connor [:mconnor]]

Sorry for confusion, this is  on top of bug 840124 which removes that consumer.

I used the URL provided by Laura/Jake, it's an easy fix if they don't need it. :)

Comment 3

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/2cd765327a28

Comment 4

[Jim Jeffery not reading bug-mail 1/2/11]

about:healthreport - 
This change is hitting an 'Untrusted Connection Error' Page:

This Connection is Untrusted
      
      
      
      
        
          You have asked Nightly to connect
securely to fhr.cdn.mozilla.net, but we can't confirm that your connection is secure.
          Normally, when you try to connect securely,
sites will present trusted identification to prove that you are
going to the right place. However, this site's identity can't be verified.
        
        
        
          What Should I Do?
          
            If you usually connect to
this site without problems, this error could mean that someone is
trying to impersonate the site, and you shouldn't continue.
            
          
        
        
        
        
          
        
        fhr.cdn.mozilla.net uses an invalid security certificate.

The certificate is not trusted because no issuer chain was provided.

(Error code: sec_error_unknown_issuer)

Comment 5

[Gregory Szorc [:gps]]

A real cert should be installed in the next 48 hours.

Comment 6

[Laura Thomson :laura]

Yep, right now it's a Mozilla-signed cert. jakem has ordered the real one.

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 726982 [details] [diff] [review]
v1 - switch to final URL, start using urlFormatter

[Approval Request Comment]
Bug caused by (feature/regressing bug #): n/a
User impact if declined: FHR will fail to function properly
Testing completed (on m-c, etc.): On Nightly since yesterday.
Risk to taking this patch (and alternatives if risky): low risk, entirely contained to FHR.
String or IDL/UUID changes made by this patch: None.

Comment 8

[bhavana bajaj [:bajaj]]

Comment on attachment 726982 [details] [diff] [review]
v1 - switch to final URL, start using urlFormatter

I am sure the url will get testing by many of us once we get the cert, but in case there is anything additional needed here from QA please add qawanted here.

Comment 9

[Mike Connor [:mconnor]]

http://hg.mozilla.org/releases/mozilla-aurora/rev/aa391e2a2508

Comment 10

[u279076]

Verified that both Nightly and Aurora now point to https://fhr.cdn.mozilla.net/%LOCALE%/