852803 - nsHTMLCanvasFrame calls nsSplittableFrame::Init, not nsContainerFrame::Init

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Boris Zbarsky [:bzbarsky]]

But it inherits from nsContainerFrame.  Is this purposeful?

Looks like this was added in bug 610727.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I don't think so.

Comment 2

[Timothy Nikkel (:tnikkel)]

Actually at the time of bug 610727 it actually inherited from nsSplittableFrame. http://hg.mozilla.org/mozilla-central/rev/0d48a869291f changed it to nsContainerFrame and missed one spot.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: nsHTMLCanvasFrame::Init should call its superclass' init, not some random ancestor class.

Comment 4

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c049e8fe62e9

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c049e8fe62e9