85283 - Static build on OS/2

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[jhp (no longer active)]

Build static build on OS/2.  Based on the linux code from 
bug 46775.

Comment 1

[jhp (no longer active)]

Attachment: patch for os/2 changes

Comment 2

[jhp (no longer active)]

With the changes from the above patch, as well as those in 
bugs 84153 and 83878, the os/2 static build successfully 
comes up.  The only problem (happens on os/2 but not on 
linux) is this assertion:

Assertion: nsLocaleModule: Module already created: 
'gModule==NULL', file 
intl/locale/src/os2/nsLocaleModule.cpp, line 329

Still haven't figured out why this happens.

Comment 3

[cls]

Javier, could you update the patch against the latest static build branch,
STATIC_BUILD_20010612_BRANCH ?  Waterson's pushing for getting the main static
build changes landed on Monday and I'd like to get these changes in as well.  

Comment 4

[jhp (no longer active)]

Chris:
I'm running into some problems.  The new build-list.pl perl 
file fails on OS/2.  I get this error: "grep: Bad file 
number".  Any idea why this is?  I reverted to the old file 
in order to complete the build.  I'll post a patch as soon 
as I can, but it probably won't be until tuesday.

Comment 5

[cls]

build-list.pl was changed to use the output of the grep -c command rather than
the return value of grep.  Not sure why you would be getting that error.  Can
you remove the @ from the cmdline that runs build-list so we can see what
command it is actually trying to use?

Comment 6

[jhp (no longer active)]

Well, I'm not sure exactly what you want, but here is the 
command as it gets called:

D:/EMX/bin/perl.exe D:/mozilla/config/build-list.pl 
../../config/final-link-libs mozjs

And it fails on the line:

open(RES, "grep -c '^$entry\$' $file |") or $err = $!;

Not sure exactly why, but it works correctly if I remove 
"or $err = $!" from the end of the line.  Any idea about 
what is going on?

Also, does this check to see if the module is already 
written in the file?  Maybe it is due to my hack, but if I 
remove the end of the line, I can write multiple instances 
of an entry to the file.

Comment 7

[jhp (no longer active)]

Attachment: updated patch

Comment 8

[jhp (no longer active)]

Latest patch is updated to the 
STATIC_BUILD_20010612_BRANCH.  Build-list.pl problems are 
still unresolved.

Comment 9

[cls]

Waterson, could you take a look at the non-OS2 specific portions of the patch? 
Mkaply, could you take a look at the OS2 specific portions of the patch?

Comment 10

[Mike Kaply [:mkaply]]

r=mkaply on the OS/2 stuff.

Comment 11

[Chris Waterson]

r=waterson

Comment 12

[jhp (no longer active)]

cls:
Any input on the build-list.pl problem?

Comment 13

[jhp (no longer active)]

Finally solved our build-list.pl problem.  The perl distribution on 
OS/2 emulates flock, which was causing our problems.  By setting 
USE_PERL_FLOCK=0, we fall back on the flock in EMX (nonfunctional, 
just a stub; same a passing -l to build-list.pl).  Also needed to use 
the sh.exe shell that comes with perl.  Will soon update instructions 
at www.mozilla.org/ports/os2.

Everything is ready to go now.

Comment 14

[cls]

The updated patch has been checked in.  I think we can work around the flock
problem by using config/mozLock.pm instead of perl's builtin flock().  I keep
meaning to switch the scripts that use locking over to it but never find the
time....

Comment 15

[jhp (no longer active)]

verified