Closed
Bug 852962
Opened 12 years ago
Closed 12 years ago
Bad optionsURL will show 'options' header but no options
Categories
(Firefox for Android Graveyard :: Add-on Manager, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 22
People
(Reporter: mfinkle, Unassigned)
Details
Attachments
(1 file)
|
2.60 KB,
patch
|
Margaret
:
review+
|
Details | Diff | Splinter Review |
Some add-ons have an optionsURL in the install.rdf that is designed for desktop Firefox, not mobile. This will fail to load because we only check for legal <settings> elements in the options file. However, the "Options" header will still display, which is bad.
This patch will reset the "optionsURL" attribute on the details item, to hide the "Options" header and reset the attribute on the list item, so we don't even attempt to show options next time.
Attachment #727200 -
Flags: review?(margaret.leibovic)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 727200 [details] [diff] [review]
patch
Thanks for fixing this!
Attachment #727200 -
Flags: review?(margaret.leibovic) → review+
|
Reporter | |
Comment 2•12 years ago
|
||
|
||
Comment 3•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•