Closed Bug 852986 Opened 11 years ago Closed 11 years ago

Regression: Google search results completely zoomed in on browser back

Categories

(Firefox for Android Graveyard :: Toolbar, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox19 unaffected, firefox20 unaffected, firefox21 unaffected, firefox22+ verified, fennec22+)

RESOLVED FIXED
Tracking Status
firefox19 --- unaffected
firefox20 --- unaffected
firefox21 --- unaffected
firefox22 + verified
fennec 22+ ---

People

(Reporter: aaronmt, Assigned: wesj)

References

Details

(Keywords: regression, reproducible)

Attachments

(1 file)

Currently when I tap a result off of Google and hit the back button, the search results window is entirely zoomed in.

Steps to reproduce

i) http://google.ca
ii) Search for 'toronto weather'
iii) Tap the first result, 'Weather Forecast: Toronto, Ontario...'
iv) Hit the browser back button.

See screenshot

--
LG Nexus 4 (Android 4.2.2)
Nightly (03/20)
Attachment #727228 - Attachment description: Nightly (03/20) - Screenshot → Nightly (03/20) - Screenshot [before|after]
Keywords: regression
Summary: Google search results completely zoomed in on browser back → Regression: Google search results completely zoomed in on browser back
tracking-fennec: --- → ?
Kats - Looks like the viewport meta info is not being reset when going back (onpageshow/onpagehide). Any ideas?
Assignee: nobody → bugmail.mozilla
tracking-fennec: ? → 22+
I'm able to reproduce but I don't know offhand what's causing this. It looks like it is specific to some search results and not others. For example, when I searched for toronto weather as in comment #0, the first result has this problem but other results do not.

(In reply to Mark Finkle (:mfinkle) from comment #1)
> Kats - Looks like the viewport meta info is not being reset when going back
> (onpageshow/onpagehide).

What makes you say this? We don't do anything particular with onpageshow/onpagehide, and never have, as far as I know. So if this is related to onpageshow/onpagehide, then it may be a regression from core gecko code.
Kats, what is your plan for this?
Flags: needinfo?(bugmail.mozilla)
This is fixed now. Bisecting nightlies and inbounds shows it was fixed by bug 856497.
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(bugmail.mozilla)
Resolution: --- → DUPLICATE
Is there a subset of bug 858969 that we can take to resolve these zoom issues Chris?
Assignee: bugmail.mozilla → chrislord.net
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Flags: needinfo?(chrislord.net)
Are you sure that just picking up the patch from 856497 doesn't fix the problem? That is what my bisection showed as the fix.
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #8)
> Are you sure that just picking up the patch from 856497 doesn't fix the
> problem? That is what my bisection showed as the fix.

That's a huge patch, so we'd rather not take it in FF22 for the last 3 betas.
I'm thinking that this is likely caused by the changes in browser.js. A patch that would roll back the changes made for bug 716403 in this file ought to help fix this problem without causing any other issues (if the pref is enabled, odd behaviour may occur though)

I'm on PTO for 2 weeks, I'm hoping that Margaret or Wes could handle this?
Flags: needinfo?(wjohnston)
Flags: needinfo?(margaret.leibovic)
Flags: needinfo?(chrislord.net)
Assignee: chrislord.net → wjohnston
Flags: needinfo?(wjohnston)
Just glancing at this, it seems like the patch in:

https://bug856497.bugzilla.mozilla.org/attachment.cgi?id=734646

is pretty small. I'm going to build it and test locally. A backout of bug 716403 seems much larger to cause problems to me.
Sorry for the delay. Managed to run this through beta, and the patch does fix the problem for me. At this point, I'm more comfortable with the idea of taking the fix than backing out all of the dynamic toolbar and hoping that everything still works.

I can try to reduce the patch down a bit to minimize its surface area, but I'm not sure how successful that will be.
Flags: needinfo?(margaret.leibovic)
wesj - there was a misunderstanding. I thought we were talking about patches from bug 858969, which bug 856497 is duped to. We can move forward with this small patch.
Bug 856497 has medium risk, which means we'd really like to get extra QA verification around the toolbar if/when this lands.
Depends on: 856497
Keywords: qawanted, verifyme
Aaron - can you verify? Thanks!
QA Contact: aaron.train
This is fixed on mozilla-beta (Fx22).
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Keywords: qawanted, verifyme
Resolution: --- → FIXED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: