Closed Bug 85300 Opened 24 years ago Closed 24 years ago

Form Manager saved data viewer is broken

Categories

(Toolkit :: Form Manager, defect, P1)

Product:
Toolkit
Component:
Form Manager
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: sfraser_bugs, Unassigned)

References

Details

Attachments

(2 files)

patch
12.11 KB, patch
Details | Diff | Splinter Review
screenshot of creditcard panel
14.07 KB, image/gif
Details
Choosing 'View Saved Data' on the Edit menus results in the following: JavaScript error: chrome://communicator/content/wallet/WalletViewer.js line 123: elementIDs has no properties and a window with blank right-hand panel. None of the form data can be viewed.
Hardware: Macintosh → All
What build are you using?
Using a current tip build. Saw on Mac and windows.
*** This bug has been marked as a duplicate of 64325 ***
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → DUPLICATE
We already know about this -- see bug 62730 for more details. I'm going to close out that bug (rather than morph it) and keep this one as the tracking bug for this new symtptom. cc'ing all people from that other bug report into this one.
No, this isn't a dup of bug 64325. That's an old bug with different symptoms and a different cause. I'm undupping these two reports.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Status: REOPENED → ASSIGNED
Target Milestone: --- → mozilla0.9.2
I'm still waiting for ftang to respond to my question that was in bug 62730 (which has now become this bug). Namely: ftang, can you revise the patch to avoid this regression? I'm referring to ftang's patch in bug 62730 which is the cause of the current problem.
To clarify, it's the 2001-05-30 14:28 from bug 62730 that I'm talking about.
Blocks: 82655
Blocks: 83724
Blocks: 62722
*** Bug 85659 has been marked as a duplicate of this bug. ***
OS: Mac System 8.5 → All
Adding johng, tpringle and momoi to cc: list. Marking as nsbeta1, nsCatFood, and nsDogFood.
Severity: normal → blocker
Keywords: nsbeta1, nsCatFood, nsdogfood
reassigning to ftang at his request.
Assignee: morse → ftang
Status: ASSIGNED → NEW
It is totally my fault.
mark it P1
Status: NEW → ASSIGNED
Priority: -- → P1
I hate this!!! I cannot reproduce this problem in my local tree.... What is missing there ? I can reproduce this in nhotta's tree, but not my tree.....
Do a complete clobber build -- that might help you to see it.
ok. now I can reproduce this.
steve mores and me agree that we should back out the last patch for now and find out what to do the right thing as the second step.
Attached patch patch — — Splinter Review
I think I find a solution. See the patch. This fix the problem without backout the origional patch.
i back out the http://bugzilla.mozilla.org/showattachment.cgi?attach_id=36541 in the trunk after steve agree. steve: can you review my new patch and try it in your tree/ I will on vacation tomorrow, if you have no problem with the patch, can you send to sr for me ?
Looks good to me. r=morse alecf, please sr
I thought this got checked in yesterday? Anyway, sr=alecf
Alec: No, this didn't get checked in, What happened yesterday was that the old checkin (which caused all the problems) got backed out.
All fixed now. Yesterday ftang backed out his original patch which of course made this bug go away. And after that he came up with what the patch should have been in the first place, and I just checked that in for him.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
break again. reopen
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
remove morse' check in 6/15 since it break the 6/18 build. now it really fix the problem
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
Still not fixed on Mac 2001061908
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
The fact that is suddenly broke again is a new bug. See bug 86726. Reclosing this one.
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
And why is this new bug already closed again with reference to ftang's fixes? I can only state that it still (20001061914, linux, modernskin) DOES NOT WORK. The first panel (Name) comes up right, all other panels remain blank --- but most panels will eventually appear when you resize the dialog. But even when they appear, The layout is broken when dropdown lists are used (see attached screenshot of the creditcard panel es an example). Basically the situation is not better than it was some weeks ago.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
morse check in the content package changes (the broken one) at Jun 7 17:54. 9I finally fix the content package chagnes to the right state, as I believe, monday afternoon) Therefore, we should compare 6/7/2000 08000 build against 200010619 mac and linux build. If they are the same, then it have nothing to do with the content package changes.
About Linux: >And why is this new bug already closed again with reference to ftang's fixes? >I can only state that it still (20001061914, linux, modernskin) DOES NOT WORK. >The first panel (Name) comes up right, all other panels remain blank I test linux 060613 build with ji@netscape.com . That build does not include the content package changes morse check in bug 62730. And it behave the same as above. Therefore, we can proff that the content package changes have no impact on the above behavior. It does not break it , neither fix it.
>I test linux 060613... actually, I test 060613-branc (moz0.9.1) and moz0601-trunk build. both of them behave as today's linux build. which mean it is really a differnt bug- not caused by : >JavaScript error: >chrome://communicator/content/wallet/WalletViewer.js line 123: elementIDs has no properties
So which bug is the correct one to follow w.r.t the current situation? this one here or bug 86726?
mark this bug close. The current mac display problem is a seperate cause, exist in beta1 and have no relationship from the content package seperate work- I reopen 86726. The current linux display problme is a sepertae bug , exist in beta1 and have no relationship from the content package seperate work- Please file seperate bug against morse for it. close this bug since the origional report cause is gone and my duty of moving those file to US.jar is finish and done.
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
86276 is for mac. I am not sure it is the problem for linux or not. Maybe you should open a new bug for linux. But THIS 85300 is about "JavaScript error: chrome://communicator/content/wallet/WalletViewer.js line 123: elementIDs has no properties" and no longer exist.
Verified javascript error fixed: W2k build 2001062004 mac build 2001062005 linux build 2001062008
Status: RESOLVED → VERIFIED
I'm still seeing this on the branch Linux build 2001062506. This first forms are displayed. Click on address, phone numbers or anything else and the forms disappear, even if saved information is present. There is no javascript error, though.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
This bug has been fixed. What you are now reporting is a different bug -- namely 86726.
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
Verified fixed, this bug is only for the javascript error and that has been fixed
Status: RESOLVED → VERIFIED
Assignee: ftang → nobody
Product: Core → Toolkit
QA Contact: tpreston → form.manager
Target Milestone: mozilla0.9.2 → ---
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: