853022 - Remove "Ideas" from feedback app

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Tyler Downer [He/Him]]

With Input 2.0, the ideas category is going away. We should remove this option from the feedback solicitation app or else all Ideas will be thrown into Sad, possibly skewing the data.

Comment 1

[Aaron Train [:aaronmt]]

That's a good idea.

Comment 2

[:Margaret Leibovic]

Attachment: patch

Maybe we should get some UX feedback on whether or not we want to update this now that there's only 2 options, but this is the simple solution.

I also just noticed that the footer goes off screen the first time about:feedback is opened - seems like a dynamic toolbar bug.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 727364 [details] [diff] [review]
patch

Looks good

Comment 4

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/389667c99555

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/389667c99555

Comment 6

[Tyler Downer [He/Him]]

Can we get this uplifted to 20 or 21? The new input will be launching soon, so the faster we can get this into release the better. Thanks for the prompt turnaround.

Comment 7

[:Margaret Leibovic]

Comment on attachment 727364 [details] [diff] [review]
patch

I think it's probably too late to land this on beta, although it is extremely low risk, so maybe we could squeeze it in? For now, I'm just requesting aurora approval.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): n/a
User impact if declined: users will think they're submitting idea feedback, but it will really just get lumped in with sad feedback when the new input.mozilla.org goes live
Testing completed (on m-c, etc.): landed on m-c
Risk to taking this patch (and alternatives if risky): low-risk, deletes an option from about:feedback
String or UUID changes made by this patch: n/a (only removals)

Comment 8

[bhavana bajaj [:bajaj]]

Comment on attachment 727364 [details] [diff] [review]
patch

low risk patch and given the ideas will not be of any help the new Input goes live, we are just removing that option for users

Comment 9

[bhavana bajaj [:bajaj]]

(In reply to Tyler Downer [:Tyler] from comment #6)
> Can we get this uplifted to 20 or 21? The new input will be launching soon,
> so the faster we can get this into release the better. Thanks for the prompt
> turnaround.

A quick spotcheck with the new input(hoping it will be landed by Fx21 release) once this lands will be helpful :) Thanks in advance for your help !

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/caf6ea63dc25

Comment 11

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
Build: Firefox for Android 23.0a1 (2013-04-21) and Firefox for Android 22.0a2 (2013-04-21)
Device: LG Nexus 4
OS: Android 4.2.2

Comment 12

[Paul Feher]

Verified on Firefox for Android 21.0b7 and Aurora 22.0a2 (2013-05-07) using: Nexus 4 (4.2.2)