853033 - nsIPrintSettings should have IID revved

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[bhavana bajaj [:bajaj]]

http://hg.mozilla.org/mozilla-central/rev/8de609c5d378 changeset (Bug 743252 ) missed the IID change with the  interface nsIPrintSettings : nsISupports being modified

Comment 1

[bhavana bajaj [:bajaj]]

Julian, looks like the patch (Bug 743252 ) adds a new attribute in "b/widget/nsIPrintSettings.idl" . Does IID need to be revved in this case ? If so can you please help with a patch asap.

Comment 2

[Julian Viereck]

Attachment: Changes uuid.

Changes uuid.


Try push (still running):

https://tbpl.mozilla.org/?tree=Try&rev=9795ca37d8f4

Comment 3

[Justin Lebar (not reading bugmail)]

Comment on attachment 729497 [details] [diff] [review]
Changes uuid.

r=me

Comment 4

[Julian Viereck]

Try run looks green -> Checkin-Needed flag.

Also requesting dev-docs-needed as the UUID changed and someone pointed out that might be a good thing todo.

Comment 5

[Julian Viereck]

Comment on attachment 729497 [details] [diff] [review]
Changes uuid.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 743252
User impact if declined: Addons might break due to not updated UUID.
Testing completed (on m-c, etc.): Try run, not landed on m-c at point of making approval request
Risk to taking this patch (and alternatives if risky): Very low risk
String or UUID changes made by this patch: nsIPrintSession

Comment 6

[Julian Viereck]

Comment on attachment 729497 [details] [diff] [review]
Changes uuid.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 743252
User impact if declined: Addons might break due to not updated UUID.
Testing completed (on m-c, etc.): Try run, not landed on m-c at point of making approval request
Risk to taking this patch (and alternatives if risky): Very low risk
String or UUID changes made by this patch: nsIPrintSession

Comment 7

[Benjamin Smedberg]

Comment on attachment 729497 [details] [diff] [review]
Changes uuid.

This is a mess.

First, I'm pretty sure that this doesn't affect release (but we absolutely wouldn't approve a UUID change there anyway).

Second, we don't change interfaces or UUIDs on beta. So the fact that bug 743252 already landed on beta means we're kinda screwed here either way.

I don't understand why jorgev gave ba= to this in the first place... it seems like the kind of change that should automatically be rejected :-(

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bb210464e583

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 729497 [details] [diff] [review]
Changes uuid.

I'm not sure if we'll uplift this yet, but fwiw mozilla-release now have FF20 on it since we did the merge yesterday so resetting the nom flag in case we do take this uplift - we'll build FF20 off of mozilla-release repo which will need this included.

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

After discussing with Benjamin the call is to leave this out of FF20 (and notify certain addon authors we know need to be in the loop on this: F-Secure, Avira, Norton, and Skype).  This is similar to what we did in FF19 with bug 838668.  We should take this to mozilla-aurora right away so we don't run into this on FF21 when it merges to Beta on Monday.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bb210464e583

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ac5ed16b6a74