853049 - nsIDOMMozIccManager should have IID revved

Status: RESOLVED WONTFIX

(Core :: DOM: Device Interfaces, defect)

Description

[bhavana bajaj [:bajaj]]

http://hg.mozilla.org/mozilla-central/rev/0f0d01f00f1e (Bug 847820)

Comment 1

[Edgar Chen [:edgar]]

Hi :bajaj,

I think the IID issue of IccManager in bug 851302 is caused by former rev.
http://hg.mozilla.org/mozilla-central/rev/7e5295f718b3

In the latest rev, http://hg.mozilla.org/mozilla-central/rev/0f0d01f00f1e, I did modify the IID of IccManager.
Could you help to check the IID issue of IccManager is still there with latest m-c?

If there is any thing I can help, please just let me know.

Thank in advance :)

Comment 2

[bhavana bajaj [:bajaj]]

(In reply to Edgar Chen [:edgar][:echen] from comment #1)
> Hi :bajaj,
> 
> I think the IID issue of IccManager in bug 851302 is caused by former rev.
> http://hg.mozilla.org/mozilla-central/rev/7e5295f718b3
> 
> In the latest rev, http://hg.mozilla.org/mozilla-central/rev/0f0d01f00f1e, I
> did modify the IID of IccManager.
> Could you help to check the IID issue of IccManager is still there with
> latest m-c?
> 
> If there is any thing I can help, please just let me know.
> 
> Thank in advance :)

Thanks for looking into this :) I am going to needsinfo folks involved with "http://hg.mozilla.org/mozilla-central/rev/0f0d01f00f1e" to check on this

Comment 3

[bhavana bajaj [:bajaj]]

(In reply to Edgar Chen [:edgar][:echen] from comment #1)
> Hi :bajaj,
> 
> I think the IID issue of IccManager in bug 851302 is caused by former rev.
> http://hg.mozilla.org/mozilla-central/rev/7e5295f718b3

:mounir, Edgar suggest's that the above changeset would have caused the missing IID rev, can you please check if that's the case and get the needed change ready ? Thanks !

> In the latest rev, http://hg.mozilla.org/mozilla-central/rev/0f0d01f00f1e, I
> did modify the IID of IccManager.
> Could you help to check the IID issue of IccManager is still there with
> latest m-c?
> 
> If there is any thing I can help, please just let me know.
> 
> Thank in advance :)

Comment 4

[Mounir Lamouri (:mounir)]

Indeed, the iid wasn't changed with bug 840780 but given that this is a B2G interface I wouldn't worry much about it. However, assigning the bug to Siddartha in case of he can do something about it.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Hi, Mounir
Can you suggest how to fix this?
Since the newer version of IccManager has been check-in already.

Comment 6

[Mounir Lamouri (:mounir)]

(In reply to Yoshi Huang[:allstars.chh][:yoshi] from comment #5)
> Hi, Mounir
> Can you suggest how to fix this?
> Since the newer version of IccManager has been check-in already.

Indeed, there is nothing to do in mozilla-central, the fix would consist in changing the uuid in mozilla-aurora https://hg.mozilla.org/releases/mozilla-aurora/

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Mounir Lamouri (:mounir) from comment #6)
Hi, Mounir
In Aurora, Bug 840780 hasn't been checked in yet.

Do you mean we need to create another patch of Bug 840780 for Aurora?
In that case, Bug 847820 is landed after Bug 840780, should we also create another patch of Bug 847820 for Aurora?
And how do we prevent those original patches(no revID changed) in both bugs who are already landed in m-c to land in m-a? 

Or in this bug we provide a patch for rev ID changed only,
but how do we make sure this patch could be check-in between Bug 840780 and Bug 847820 on m-a?

thanks

Comment 8

[Mounir Lamouri (:mounir)]

The required patch is a one-liner (just changing the iid) but given that aurora is now uplifted to mozilla-beta, if this lands, it needs to be in m-b, not m-a.

Comment 9

[Benjamin Smedberg]

Given that by rule we don't rev IIDs after the first beta, we either need to do this immediately for FF20 or not at all. I don't think it matters in this case because binary extensions are not going to use this interface. So I'm going to take the liberty of marking this WONTFIX and letting you guys work on more important things.