853092 - During `cfx test`, the output is polluted by several "info: add-on sdk:" messages in page-mod

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Matteo Ferretti [:zer0] [:matteo]]

When `cfx test` is executed, we got in the middle of the execution some output messages:

info: addon-sdk: Open iframe in hidden window
info: addon-sdk: Open toplevel window
info: addon-sdk: Open iframe in browser window
info: addon-sdk: Open iframes in a tab

They seems a result of a `console.log`, that should never be called during unit test, unless the console is properly mocked.

These messages should be removed if they're left over, or the console should be properly mocked, if they're intended to be there.

Comment 1

[Matteo Ferretti [:zer0] [:matteo]]

We also have:

info: addon-sdk: executing: text
info: addon-sdk: executing: html
info: addon-sdk: executing: image
info: addon-sdk: executing: web
info: addon-sdk: executing: click
info: addon-sdk: executing: mouseover
info: addon-sdk: executing: mouseout
info: addon-sdk: executing: click
info: addon-sdk: executing: mouseover
info: addon-sdk: executing: mouseout
info: addon-sdk: executing: content
info: addon-sdk: executing: content
info: addon-sdk: executing: text
info: addon-sdk: executing: fallback
info: addon-sdk: executing: tooltip
info: addon-sdk: executing: allow
info: addon-sdk: executing: allow
info: addon-sdk: executing: allow
info: addon-sdk: executing: first
info: addon-sdk: executing: second
info: addon-sdk: executing: first

that I believe comes from context-menu.

Comment 2

[Dave Townsend [:mossop]]

I just ran the context-menu tests and nothing like that was logged, and neither test-context-menu or context-menu contain console.log

Comment 3

[Matteo Ferretti [:zer0] [:matteo]]

Okay, it seems that they comes respectively from:

https://github.com/mozilla/addon-sdk/blob/master/test/test-page-mod.js#L545
https://github.com/mozilla/addon-sdk/blob/master/test/test-page-mod.js#L567
https://github.com/mozilla/addon-sdk/blob/master/test/test-page-mod.js#L577
https://github.com/mozilla/addon-sdk/blob/master/test/test-page-mod.js#L593

and:

https://github.com/mozilla/addon-sdk/blob/master/test/test-widget.js#L161

Comment 5

[Alexandre Poirot [:ochameau]]

Actually, these messages are helpfull when you work on these tests,
that's because some of our test are huge and are executed in only one exported test function, that's particularely true for widget. So we have many distinct tests being done in one test export. So without this console.info, we do not know which one we are currently executing.
In verbose mode, for widget, you would have "executing test-widget:testConstructor" executing a lot of tests that would not print any "starting xxx test" message.

I think that's a regression, I remember explicitely changing console.log to console.info because of this. We should be able to call a console method that prints in verbose and not in non-verbose.

Comment 6

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Alexandre Poirot (:ochameau) from comment #5)
> Actually, these messages are helpfull when you work on these tests,
> that's because some of our test are huge and are executed in only one
> exported test function, that's particularely true for widget. So we have
> many distinct tests being done in one test export. So without this
> console.info, we do not know which one we are currently executing.
> In verbose mode, for widget, you would have "executing
> test-widget:testConstructor" executing a lot of tests that would not print
> any "starting xxx test" message.
> 
> I think that's a regression, I remember explicitely changing console.log to
> console.info because of this. We should be able to call a console method
> that prints in verbose and not in non-verbose.

Ok I think we should use `assert.pass` instead because `console.log` prints regardless of the `-v` flag.

Comment 7

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Erik Vold [:erikvold] [:ztatic] from comment #6)
> (In reply to Alexandre Poirot (:ochameau) from comment #5)
> > I think that's a regression, I remember explicitely changing console.log to
> > console.info because of this. We should be able to call a console method
> > that prints in verbose and not in non-verbose.
> 
> Ok I think we should use `assert.pass` instead because `console.log` prints
> regardless of the `-v` flag.

Oops missed that last bit of your message Alex :/

What Alex said! +1

Comment 8

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: https://github.com/mozilla/addon-sdk/pull/1394

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/61bd2e32dca4164d9837c38c579118005a141bc2
Bug 853092 - During `cfx test`, the output is polluted by several "info: add-on sdk:" messages in page-mod

https://github.com/mozilla/addon-sdk/commit/5ede77e52eaf8b05f83f5b090f0c31ba59204365
Merge pull request #1394 from erikvold/853092

Bug 853092 - During `cfx test`, the output is polluted by several "info: add-on sdk:" messages in page-mod r=@ZER0