Closed
Bug 853162
Opened 12 years ago
Closed 10 years ago
Remove XMLHttpRequest sendAsBinary
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: annevk, Assigned: djc)
References
Details
(Keywords: addon-compat, dev-doc-needed, site-compat, Whiteboard: [good first bug])
Attachments
(1 file, 1 obsolete file)
|
10.78 KB,
patch
|
djc
:
review+
|
Details | Diff | Splinter Review |
It is proprietary and unneeded as far as I can tell. And per bug 681931 might be leaking?
|
||
Comment 1•12 years ago
|
||
Seems to be used when people don't want a content-type set. See bug 416178 comment 31
|
Reporter | |
Comment 2•12 years ago
|
||
You should get the same behavior per spec if you pass a Blob without a type to send(). But yes, we should warn about this going away first.
I agree. lets warn about this for a release or two and then nuke it. But we should be prepared to put it back temporarily if it's breaking high usage websites.
Depends on: 939323
|
||
Updated•11 years ago
|
Keywords: dev-doc-needed
|
||
Updated•11 years ago
|
|
|
Reporter | |
Comment 4•10 years ago
|
||
It seems this has been deprecated since Firefox 31. Time to remove it?
Whiteboard: [good first bug]
|
Assignee | |
Comment 5•10 years ago
|
||
Initial version of a patch, pretty much just grepping through the source and removing stuff that seems related.
Assignee: nobody → dirkjan
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8561031 -
Flags: review?(Ms2ger)
|
|
Assignee | |
Comment 6•10 years ago
|
||
Comment on attachment 8561031 [details] [diff] [review]
Initial version of patch
Asking smaug to review based on comment from Ms2ger.
Attachment #8561031 -
Flags: review?(Ms2ger) → review?(bugs)
|
||
Comment 7•10 years ago
|
||
Comment on attachment 8561031 [details] [diff] [review]
Initial version of patch
Could we land this for FF39, so that ESR38 would still have the warning -
just in case some intranet site uses the property.
Update uuid of nsIXMLHttpRequest.
Attachment #8561031 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 8•10 years ago
|
||
So I should just bump the UUID and then we'll hold off for two more weeks?
|
|
Assignee | |
Comment 9•10 years ago
|
||
Pushed to try with updated UUID:
https://hg.mozilla.org/try/rev/d73752326327
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d73752326327
|
|
Assignee | |
Comment 10•10 years ago
|
||
Add new patch for landing.
Attachment #8561031 -
Attachment is obsolete: true
Attachment #8568993 -
Flags: review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 11•10 years ago
|
||
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
|
||
Updated•10 years ago
|
Keywords: addon-compat
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•