853162 - Remove XMLHttpRequest sendAsBinary

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Anne (:annevk)]

It is proprietary and unneeded as far as I can tell. And per bug 681931 might be leaking?

Comment 1

[Robert Longson [:longsonr]]

Seems to be used when people don't want a content-type set. See bug 416178 comment 31

Comment 2

[Anne (:annevk)]

You should get the same behavior per spec if you pass a Blob without a type to send(). But yes, we should warn about this going away first.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I agree. lets warn about this for a release or two and then nuke it. But we should be prepared to put it back temporarily if it's breaking high usage websites.

Comment 4

[Anne (:annevk)]

It seems this has been deprecated since Firefox 31. Time to remove it?

Comment 5

[Dirkjan Ochtman (:djc)]

Attachment: Initial version of patch

Initial version of a patch, pretty much just grepping through the source and removing stuff that seems related.

Comment 6

[Dirkjan Ochtman (:djc)]

Comment on attachment 8561031 [details] [diff] [review]
Initial version of patch

Asking smaug to review based on comment from Ms2ger.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8561031 [details] [diff] [review]
Initial version of patch

Could we land this for FF39, so that ESR38 would still have the warning - 
just in case some intranet site uses the property.

Update uuid of nsIXMLHttpRequest.

Comment 8

[Dirkjan Ochtman (:djc)]

So I should just bump the UUID and then we'll hold off for two more weeks?

Comment 9

[Dirkjan Ochtman (:djc)]

Pushed to try with updated UUID:

https://hg.mozilla.org/try/rev/d73752326327
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d73752326327

Comment 10

[Dirkjan Ochtman (:djc)]

Attachment: Patch with updated UUID

Add new patch for landing.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0ccbd75a97c7

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0ccbd75a97c7