853169 - qcms increment is not threadsafe

Status: RESOLVED FIXED

(Core :: Graphics: Color Management, defect)

Description

[Joe Drew (not getting mail)]

Attachment: fix

Comment 1

[Joe Drew (not getting mail)]

Attachment: initialize output profile in gfxPlatform::Init

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 727369 [details] [diff] [review]
fix

Review of attachment 727369 [details] [diff] [review]:
-----------------------------------------------------------------

+1

Comment 3

[Joe Drew (not getting mail)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/eca6b3ea3e8d
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/d77773a8abf9

Comment 4

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/4f471bdd6122 for Linux xpcshell crashes in test_async_notification.js, test_imgtools.js and test_favicons_conversions.js

Comment 5

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=20915182&tree=Mozilla-Inbound for a random log.

Comment 6

[Joe Drew (not getting mail)]

Attachment: initialize output profile in gfxPlatform::init, handle null display

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 728021 [details] [diff] [review]
initialize output profile in gfxPlatform::init, handle null display

Review of attachment 728021 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxPlatformGtk.cpp
@@ +490,5 @@
>      Atom edidAtom, iccAtom;
>      Display *dpy = GDK_DISPLAY_XDISPLAY(gdk_display_get_default());
> +    if (!dpy) {
> +        return NULL;
> +    }

Add a comment about when we won't have a display.

Comment 8

[Joe Drew (not getting mail)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/c0befbf2533d 
http://hg.mozilla.org/integration/mozilla-inbound/rev/2e318d0a172b

Comment 9

[Joe Drew (not getting mail)]

Backed out again, because it was in a push with mysterious crashes in crashtests.

Pushed on its own: https://tbpl.mozilla.org/?tree=Try&rev=f6ecd22107bb

Comment 10

[Phil Ringnalda (:philor)]

Not you, it happened again above your backout.

Comment 11

[Phil Ringnalda (:philor)]

Relanded in https://hg.mozilla.org/integration/mozilla-inbound/rev/8987af28db8f and https://hg.mozilla.org/integration/mozilla-inbound/rev/a92fbe6fd787

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8987af28db8f
https://hg.mozilla.org/mozilla-central/rev/a92fbe6fd787