Closed
Bug 853169
Opened 11 years ago
Closed 11 years ago
qcms increment is not threadsafe
Categories
(Core :: Graphics: Color Management, defect)
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: joe, Assigned: joe)
References
Details
Attachments
(2 files, 1 obsolete file)
3.53 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
3.35 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #727369 -
Flags: review?(jmuizelaar)
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #727370 -
Flags: review?(jmuizelaar)
Comment 2•11 years ago
|
||
Comment on attachment 727369 [details] [diff] [review] fix Review of attachment 727369 [details] [diff] [review]: ----------------------------------------------------------------- +1
Attachment #727369 -
Flags: review?(jmuizelaar) → review+
Updated•11 years ago
|
Attachment #727370 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Comment 3•11 years ago
|
||
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/eca6b3ea3e8d remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/d77773a8abf9
Target Milestone: --- → mozilla22
Comment 4•11 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/4f471bdd6122 for Linux xpcshell crashes in test_async_notification.js, test_imgtools.js and test_favicons_conversions.js
Target Milestone: mozilla22 → ---
Comment 5•11 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=20915182&tree=Mozilla-Inbound for a random log.
Assignee | ||
Comment 6•11 years ago
|
||
Attachment #727370 -
Attachment is obsolete: true
Attachment #728021 -
Flags: review?(jmuizelaar)
Comment 7•11 years ago
|
||
Comment on attachment 728021 [details] [diff] [review] initialize output profile in gfxPlatform::init, handle null display Review of attachment 728021 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/thebes/gfxPlatformGtk.cpp @@ +490,5 @@ > Atom edidAtom, iccAtom; > Display *dpy = GDK_DISPLAY_XDISPLAY(gdk_display_get_default()); > + if (!dpy) { > + return NULL; > + } Add a comment about when we won't have a display.
Attachment #728021 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Comment 8•11 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/c0befbf2533d http://hg.mozilla.org/integration/mozilla-inbound/rev/2e318d0a172b
Target Milestone: --- → mozilla22
Assignee | ||
Comment 9•11 years ago
|
||
Backed out again, because it was in a push with mysterious crashes in crashtests. Pushed on its own: https://tbpl.mozilla.org/?tree=Try&rev=f6ecd22107bb
Comment 10•11 years ago
|
||
Not you, it happened again above your backout.
Comment 11•11 years ago
|
||
Relanded in https://hg.mozilla.org/integration/mozilla-inbound/rev/8987af28db8f and https://hg.mozilla.org/integration/mozilla-inbound/rev/a92fbe6fd787
Comment 12•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8987af28db8f https://hg.mozilla.org/mozilla-central/rev/a92fbe6fd787
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•