Closed Bug 853169 Opened 11 years ago Closed 11 years ago

qcms increment is not threadsafe

Categories

(Core :: Graphics: Color Management, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: joe, Assigned: joe)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached patch fixSplinter Review
      No description provided.
Attachment #727369 - Flags: review?(jmuizelaar)
Attachment #727370 - Flags: review?(jmuizelaar)
Comment on attachment 727369 [details] [diff] [review]
fix

Review of attachment 727369 [details] [diff] [review]:
-----------------------------------------------------------------

+1
Attachment #727369 - Flags: review?(jmuizelaar) → review+
Attachment #727370 - Flags: review?(jmuizelaar) → review+
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/4f471bdd6122 for Linux xpcshell crashes in test_async_notification.js, test_imgtools.js and test_favicons_conversions.js
Target Milestone: mozilla22 → ---
Attachment #727370 - Attachment is obsolete: true
Attachment #728021 - Flags: review?(jmuizelaar)
Comment on attachment 728021 [details] [diff] [review]
initialize output profile in gfxPlatform::init, handle null display

Review of attachment 728021 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxPlatformGtk.cpp
@@ +490,5 @@
>      Atom edidAtom, iccAtom;
>      Display *dpy = GDK_DISPLAY_XDISPLAY(gdk_display_get_default());
> +    if (!dpy) {
> +        return NULL;
> +    }

Add a comment about when we won't have a display.
Attachment #728021 - Flags: review?(jmuizelaar) → review+
Backed out again, because it was in a push with mysterious crashes in crashtests.

Pushed on its own: https://tbpl.mozilla.org/?tree=Try&rev=f6ecd22107bb
Not you, it happened again above your backout.
You need to log in before you can comment on or make changes to this bug.