Closed Bug 853219 Opened 9 years ago Closed 9 years ago

venv setup broken since mozcrash is not listed as a dependency

Categories

(Testing :: Mochitest, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(firefox22 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)

RESOLVED FIXED
mozilla22
Tracking Status
firefox22 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- fixed

People

(Reporter: Luqman, Unassigned)

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Attached file Fix venv setup (obsolete) —
Bug 843296 broke the venv setup for b2g testing with the move from automationutils -> mozcrash.
Attachment #727422 - Flags: review?(jgriffin)
Attached patch Fix venv setup (obsolete) — Splinter Review
Forgot to mark as a patch.
Attachment #727422 - Attachment is obsolete: true
Attachment #727422 - Flags: review?(jgriffin)
Attachment #727425 - Flags: review?(jgriffin)
Comment on attachment 727425 [details] [diff] [review]
Fix venv setup

Review of attachment 727425 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/client/setup.py
@@ +13,5 @@
>  # dependencies
>  deps = ['manifestdestiny', 'mozhttpd >= 0.3',
>          'mozprocess >= 0.6', 'mozrunner >= 5.11',
> +        'mozdevice >= 0.12', 'moznetwork >= 0.21',
> +        'mozcrash']

let's specify mozcrash >= 0.5, to be safe
Attachment #727425 - Flags: review?(jgriffin) → review+
Attached patch Fix venv setupSplinter Review
Attachment #727425 - Attachment is obsolete: true
Keywords: checkin-needed
It seems silly that we have to specify this in more than one place. Can we figure out how to centralize this?
Where else is does it need to be specified?
He may be referring to mozharness, but in any case it definitely belongs here in setup.py.
Attachment #727430 - Attachment is patch: true
https://hg.mozilla.org/mozilla-central/rev/bb9dce2a4977
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.