853219 - venv setup broken since mozcrash is not listed as a dependency

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Comment 1

[Luqman Aden [:Luqman]]

Attachment: Fix venv setup

Bug 843296 broke the venv setup for b2g testing with the move from automationutils -> mozcrash.

Comment 2

[Luqman Aden [:Luqman]]

Attachment: Fix venv setup

Forgot to mark as a patch.

Comment 3

[Jonathan Griffin (:jgriffin)]

Comment on attachment 727425 [details] [diff] [review]
Fix venv setup

Review of attachment 727425 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/client/setup.py
@@ +13,5 @@
>  # dependencies
>  deps = ['manifestdestiny', 'mozhttpd >= 0.3',
>          'mozprocess >= 0.6', 'mozrunner >= 5.11',
> +        'mozdevice >= 0.12', 'moznetwork >= 0.21',
> +        'mozcrash']

let's specify mozcrash >= 0.5, to be safe

Comment 4

[Luqman Aden [:Luqman]]

Attachment: Fix venv setup

Comment 5

[(not currently active) Ted Mielczarek]

It seems silly that we have to specify this in more than one place. Can we figure out how to centralize this?

Comment 6

[Luqman Aden [:Luqman]]

Where else is does it need to be specified?

Comment 7

[Jonathan Griffin (:jgriffin)]

He may be referring to mozharness, but in any case it definitely belongs here in setup.py.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bb9dce2a4977

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/bb9dce2a4977

Comment 10

[Malini Das [:mdas] - Away, not checking bugmail]

https://hg.mozilla.org/releases/mozilla-b2g18/pushloghtml?changeset=71f7f42dee13

Comment 11

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/cc57839bcd1f