Closed Bug 853268 Opened 7 years ago Closed 7 years ago

No icons for security notifications

Categories

(SeaMonkey :: Security, defect)

defect
Not set

Tracking

(seamonkey2.18 fixed)

RESOLVED FIXED
seamonkey2.19
Tracking Status
seamonkey2.18 --- fixed

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(1 file)

Bug 817441 changed some security alerts to notifications and bug 842191 created additional notifications but they currently use the default notification icons.
Attached patch Proposed patchSplinter Review
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #727471 - Flags: review?(philip.chee)
Bug 817441 has uplifted to branches although bug 842191 is recent so I could split the patch into two parts if anyone thought it necessary.
Comment on attachment 727471 [details] [diff] [review]
Proposed patch

r=me
Attachment #727471 - Flags: review?(philip.chee) → review+
Pushed comm-central changeset 1ecdf3d24f47.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.19
Comment on attachment 727471 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): 817441 didn't add icons for its notifications
User impact if declined: Security notifications get default icons
Testing completed (on m-c, etc.): Uplifted to m-a
Risk to taking this patch (and alternatives if risky): Low
String changes made by this patch: None
Attachment #727471 - Flags: approval-comm-beta?
Attachment #727471 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.