Closed
Bug 853268
Opened 12 years ago
Closed 12 years ago
No icons for security notifications
Categories
(SeaMonkey :: Security, defect)
SeaMonkey
Security
Tracking
(seamonkey2.18 fixed)
RESOLVED
FIXED
seamonkey2.19
| Tracking | Status | |
|---|---|---|
| seamonkey2.18 | --- | fixed |
People
(Reporter: neil, Assigned: neil)
References
Details
Attachments
(1 file)
|
11.75 KB,
patch
|
philip.chee
:
review+
iannbugzilla
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
Bug 817441 changed some security alerts to notifications and bug 842191 created additional notifications but they currently use the default notification icons.
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Comment 2•12 years ago
|
||
Bug 817441 has uplifted to branches although bug 842191 is recent so I could split the patch into two parts if anyone thought it necessary.
|
||
Comment 3•12 years ago
|
||
Comment on attachment 727471 [details] [diff] [review]
Proposed patch
r=me
Attachment #727471 -
Flags: review?(philip.chee) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Target Milestone: --- → seamonkey2.19
|
|
Assignee | |
Comment 5•12 years ago
|
||
Comment on attachment 727471 [details] [diff] [review]
Proposed patch
[Approval Request Comment]
Regression caused by (bug #): 817441 didn't add icons for its notifications
User impact if declined: Security notifications get default icons
Testing completed (on m-c, etc.): Uplifted to m-a
Risk to taking this patch (and alternatives if risky): Low
String changes made by this patch: None
Attachment #727471 -
Flags: approval-comm-beta?
Attachment #727471 -
Flags: approval-comm-beta? → approval-comm-beta+
|
|
Assignee | |
Comment 6•12 years ago
|
||
|
||
Updated•12 years ago
|
status-seamonkey2.18:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•