No icons for security notifications

RESOLVED FIXED in seamonkey2.19

Status

SeaMonkey
Security
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

unspecified
seamonkey2.19
Dependency tree / graph

SeaMonkey Tracking Flags

(seamonkey2.18 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Bug 817441 changed some security alerts to notifications and bug 842191 created additional notifications but they currently use the default notification icons.
(Assignee)

Comment 1

4 years ago
Created attachment 727471 [details] [diff] [review]
Proposed patch
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #727471 - Flags: review?(philip.chee)
(Assignee)

Comment 2

4 years ago
Bug 817441 has uplifted to branches although bug 842191 is recent so I could split the patch into two parts if anyone thought it necessary.

Comment 3

4 years ago
Comment on attachment 727471 [details] [diff] [review]
Proposed patch

r=me
Attachment #727471 - Flags: review?(philip.chee) → review+
(Assignee)

Comment 4

4 years ago
Pushed comm-central changeset 1ecdf3d24f47.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

4 years ago
Target Milestone: --- → seamonkey2.19
(Assignee)

Comment 5

4 years ago
Comment on attachment 727471 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): 817441 didn't add icons for its notifications
User impact if declined: Security notifications get default icons
Testing completed (on m-c, etc.): Uplifted to m-a
Risk to taking this patch (and alternatives if risky): Low
String changes made by this patch: None
Attachment #727471 - Flags: approval-comm-beta?

Updated

4 years ago
Attachment #727471 - Flags: approval-comm-beta? → approval-comm-beta+
(Assignee)

Comment 6

4 years ago
http://hg.mozilla.org/releases/comm-beta/rev/863ec27812d6

Updated

4 years ago
status-seamonkey2.18: --- → fixed
You need to log in before you can comment on or make changes to this bug.