853308 - Expose master password login state via nsILoginManager

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

The changes in bug 839961 want to know if the master password has been entered, before triggering autocomplete. Otherwise tabbing through (blurring) a field pwmgr thinks is a login's username or password field would trigger a MP prompt, and that would be annoying.

This code already exists in nsILoginManagerCrypto, just needs exposed all the way up like uiBusy was.

Comment 1

[Matthew N. [:MattN]]

Comment on attachment 727522 [details] [diff] [review]
Patch v.1

Review of attachment 727522 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/passwordmgr/nsILoginManager.idl
@@ +244,5 @@
> +   /**
> +    * True when the master password has already been entered, and so a caller
> +    * can ask for decrypted logins without triggering a prompt.
> +    */
> +    readonly attribute boolean isLoggedIn;

I can see people initially confusing this with the logged-in state of a webpage but I suspect they'll realize it's not the case since it's just an attribute. I also questioned whether it's a good idea to use the same name for all three interfaces? I think we're unlikely to have problems with this though so r=me.

Comment 2

[Justin Dolske [:Dolske]]

Yeah, identical interfaces can be confusing when you're trying to search through source. But in cases like these I think it's good -- it's basically a low-level API poking it's way through a few layers... I've seen code in the past that had things named differently at each level, and that's _really_ confusing.

Comment 3

[Joe Drew (not getting mail)]

https://hg.mozilla.org/mozilla-central/rev/c029a287fd81