853336 - loading widget module with private-browsing permission fails

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/882

Pointer to Github pull-request

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

this will need to be uplifted, sorry guys.

Comment 3

[Erik Vold [:erikvold] (please needinfo? me)]

only https://github.com/erikvold/jetpack-sdk/commit/87cc2fdbd63c7fabc36d8e03a86fe700eacaca0e tho

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/887

Pointer to Github pull-request

Comment 5

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Comment on attachment 728001 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/887

Don't you also need the test addon update test/addons/private-browsing-supported/test-global-private-browsing.js from your previous patch?
https://github.com/erikvold/jetpack-sdk/commit/87cc2fdbd63c7fabc36d8e03a86fe700eacaca0e#diff-1

Comment 6

[[github robot]]

Commits pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/51a1d3785d2345dedb7cd9c910972ed477d3d7bb
Bug 853336: widget would fail to load for add-ons with pb permission

https://github.com/mozilla/addon-sdk/commit/b0c8626fd905804d7743a0f3ed184b083caaa3ad
Merge pull request #887 from erikvold/853336-stabilization

Bug 853336: widget would fail to load for add-ons with pb permission r=@ochameau

Comment 7

[Erik Vold [:erikvold] (please needinfo? me)]

https://github.com/mozilla/addon-sdk/commit/b0c8626fd905804d7743a0f3ed184b083caaa3ad is the only commit that needs to be uplifted.

Comment 8

[Erik Vold [:erikvold] (please needinfo? me)]

We have a fix for this on master and stabilization now.