Closed
Bug 853456
Opened 9 years ago
Closed 9 years ago
target=_blank doesn't work with <img> links
Categories
(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)
Tracking
(firefox23 verified, fennec-)
VERIFIED
FIXED
Firefox 23
People
(Reporter: eviljeff, Assigned: wesj)
References
()
Details
(Keywords: reproducible, Whiteboard: [A4A])
Attachments
(1 file)
1.04 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
from an email: it seems that there is a bug that only affects webapps on Android, whereby hyperlinks that contain an img do not open externally. Works (opens externally): <div class="image"><a href="{href}" target="_blank">{text}</a></ div> Doesn't work (opens internally): <div class="image"><a href="{href}" target="_blank"><img src="{src}"/></a></div> This issue only appears to affect the app runtime on Android, as it works fine on the Firefox beta browser on Android and on Firefox OS full screen web apps.
Comment 1•9 years ago
|
||
Putting on tracking cause this breaks compat across apps on platforms and touches on target=blank functionality, which is important for opening content outside of the app.
Whiteboard: [A4A]
Reporter | ||
Comment 2•9 years ago
|
||
Added a URL to an app that exhibits this issue. Try the video links.
Comment 3•9 years ago
|
||
This is compatibility bustage in comparison to FxOS. ==> P1
Priority: -- → P1
Updated•9 years ago
|
Keywords: reproducible
Updated•9 years ago
|
Assignee: nobody → wjohnston
Updated•9 years ago
|
tracking-fennec: --- → ?
Updated•9 years ago
|
tracking-fennec: ? → -
Comment 4•9 years ago
|
||
Explanation is needed here. This was marked tracking on web apps initiative, so I do not understand why this is not being tracked on the fennec side.
Flags: needinfo?(blassey.bugs)
Comment 5•9 years ago
|
||
It is being tracked for web apps, there for does not need to be tracked for fennec
Flags: needinfo?(blassey.bugs)
Assignee | ||
Comment 6•9 years ago
|
||
This walks the tree to find links rather than just using event.target.
Attachment #739885 -
Flags: review?(mark.finkle)
Comment 7•9 years ago
|
||
Comment on attachment 739885 [details] [diff] [review] Patch >+ while(target && !(target instanceof HTMLAnchorElement)) { nit: add a space while ( > let uri = Services.io.newURI(target.href, > target.ownerDocument.characterSet, > null); Not your change, but could you make this all one line?
Attachment #739885 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 8•9 years ago
|
||
Forgot about the nits. Wil push a follow up. https://hg.mozilla.org/integration/mozilla-inbound/rev/3c0e77a706f4
Assignee | ||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef755a443f3c
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3c0e77a706f4
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
![]() |
||
Comment 11•9 years ago
|
||
Looks like the m-i commit for the follow up had the wrong bug number. Anyways, merged to m-c here: https://hg.mozilla.org/mozilla-central/rev/ef755a443f3c
Updated•9 years ago
|
Status: RESOLVED → VERIFIED
status-firefox23:
--- → verified
Updated•1 year ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•