853457 - [Browser] Scrolling when loading hides address bar

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Jan Jongboom [:janjongboom] (inactive)]

The browser currently has code to show the address bar when we're loading a tab. Nice. However, the scroll handler doesn't take this into account and therefore when you scroll again on the page you lose the address bar and the progress indicator, which I consider a UI bug.

Comment 1

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: Patch

This patch takes this into account and keeps the address bar visible until a page is fully loaded, hiding it afterwards if we are passed the scroll threshold.

Comment 2

[Ben Francis [:benfrancis]]

This seems like a good idea, but I'd like to get UX input on this.

More generally I'd like to look at refactoring the "scroll the address bar off the screen" feature to work more like Fennec Nightly. I've filed bug 860812 for that.

Comment 3

[Jan Jongboom [:janjongboom] (inactive)]

Comment on attachment 727691 [details] [diff] [review]
Patch

f+'ing this for :jcarpenter, as he just f+'ed it in real life.

Comment 4

[Jan Jongboom [:janjongboom] (inactive)]

Ben, can you r this?

Comment 5

[Ben Francis [:benfrancis]]

Comment on attachment 727691 [details] [diff] [review]
Patch

r+me with one minor nit fixed (see pull request)

Comment 6

[Alex Keybl [:akeybl]]

UX - can you evaluate the Browser scrolling on a recent master/m-c this as a mitigating solution for bug 833795? We need to make a final decision asap. Thanks!

Comment 7

[Francis Djabri [:djabber]]

As I commented in bug #833795:

"The fix for bug #853457 solves the issue of allowing the user to halt the download if she has scrolled down the page, but I don't think it mitigates the UX impact of this bug. The content still jitters badly when the content has finished loading if the user is scrolled down the page, so the user will experience the jitter one way or another.

I'm not against deferring the fix to this bug for a later release but I certainly would want to see this bug fixed. 

Incidentally, I don't consider keeping the URL bar fixed at the top and collapsing the bottom bar, as suggested in comment 98, to be a fix for this bug. This seems to be a case of the fix being worse than the original bug."

Comment 8

[Alex Keybl [:akeybl]]

Blocking instead of bug 833795.

Comment 9

[Alex Keybl [:akeybl]]

https://bugzilla.mozilla.org/show_bug.cgi?id=833795#c118