Closed
Bug 853488
Opened 11 years ago
Closed 11 years ago
Styling tweaks for Mac XUL notification alerts
Categories
(Toolkit :: Themes, defect)
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: mstange, Assigned: mstange)
Details
Attachments
(3 files)
At the moment the fade animation isn't very effective because there's opaque gray window background behind notification box which doesn't fade away. This patch removes that background so that the animation looks as intended. Also, I got carried away and tweaked the styling a little.
Attachment #727719 -
Flags: review?(mnoorenberghe+bmo)
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Comment 2•11 years ago
|
||
Comment 3•11 years ago
|
||
Comment on attachment 727719 [details] [diff] [review] v1 It's nice to see you around again. :D
Attachment #727719 -
Flags: review?(mnoorenberghe+bmo) → review+
Assignee | ||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b48c78488fce
Comment 5•11 years ago
|
||
(In reply to Markus Stange from comment #0) > Also, I got carried away and tweaked the styling a little. Do any of the styling changes also apply to other platforms? I'd rather not have the styles diverge unless necessary for platform integration.
Flags: needinfo?(mstange)
Assignee | ||
Comment 6•11 years ago
|
||
Well, I don't know what you want the panels to look like on the other platforms. The styling changes I applied here make them look more like the native Mac Notification Center alerts. You might be able to apply some of them to the Windows / Linux ones, too, but I don't know how well we handle transparent windows and their window shadow on those platforms nowadays. Also, non-Mac platforms make more use of customizable platform theme colors, and some of the color changes I've made here might not fit with those.
Flags: needinfo?(mstange)
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b48c78488fce
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•