Closed
Bug 853497
Opened 8 years ago
Closed 8 years ago
Remove spacer view from gecko_app.xml
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 22
People
(Reporter: lucasr, Assigned: lucasr)
Details
Attachments
(1 file)
|
8.20 KB,
patch
|
cwiiis
:
review+
|
Details | Diff | Splinter Review |
Update the layout params of the gecko_layout view instead.
Attachment #727740 -
Flags: review?(chrislord.net)
|
||
Comment 1•8 years ago
|
||
Comment on attachment 727740 [details] [diff] [review] Remove spacer view Review of attachment 727740 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #727740 -
Flags: review?(chrislord.net) → review+
|
Assignee | |
Comment 2•8 years ago
|
||
Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/55f53541cd6c
|
||
Comment 3•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/55f53541cd6c
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
|
||
Comment 4•8 years ago
|
||
This patch left behind a dangling reference to toolbar_spacer: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/layout/gecko_app.xml#25
|
||
Updated•1 month ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•