853504 - When submitting a new release, on error, ship it returns on the fennec tab

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[Massimo Gervasini [:massimo]]

When submitting a release that does not validate, ship it shows always the fennec tab (first tab) instead of the one that caused the validation error.

Comment 1

[Massimo Gervasini [:massimo]]

Attachment: on error, the right tab is selected

This patch forces the selection of the 'product' tab passed in the errors list.

other changes:
* removed javascript used for radio buttons
* updated error css

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 728198 [details] [diff] [review]
on error, the right tab is selected

Review of attachment 728198 [details] [diff] [review]:
-----------------------------------------------------------------

I like the look of this, just one small thing to fix.

::: kickoff/views/submit.py
@@ +46,4 @@
>              for error in form.errors.values():
>                  errors.extend(error)
>          if errors:
> +            errors.append(product)

This is pretty hacky....how about supporting a selectedProduct or similar in the template, and defaulting it to Fennec or Firefox?

Comment 3

[Massimo Gervasini [:massimo]]

Attachment: now passing selectedProduct to template

Yes, totally hacky! 

Now passing selectedProduct=product to the template.
There is no need for a default value; if product does not exist or is not set to firefox/thunderbird, the first tab is selected automatically.

Comment 4

[Massimo Gervasini [:massimo]]

Attachment: now passing selectedProduct to template

sorry, Ben. Last patch file was totally wrong

Comment 5

[Massimo Gervasini [:massimo]]

Attachment: now passing selectedProduct to template

I've spotted another issue: when editing a release, there is red bar at the top of the page (empty errors list). 
This new patch solves this problem too.

Comment 6

[[e-mail] (:bhearsum)]

This is in production.