Lazy load SelectionHandler

RESOLVED FIXED in Firefox 22

Status

()

Firefox for Android
Text Selection
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Margaret, Assigned: Margaret)

Tracking

Trunk
Firefox 22
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 727748 [details] [diff] [review]
patch

In SelectionHandler.observe(), we ignore notifications if text selection isn't active, so we don't actually need to be registering observers in BrowserApp.startup() like the rest of the world.

Because of this, we can just move SelectionHandler into a lazily-loaded script.

The only change I made to SelectionHandler is getting rid of init/uninit and replacing them with _addObservers/_removeObservers.

I want to do some more cleanup in here, but this is a start :)
Attachment #727748 - Flags: review?(bnicholson)
Comment on attachment 727748 [details] [diff] [review]
patch

Nice, looks good.
Attachment #727748 - Flags: review?(bnicholson) → review+
(Assignee)

Comment 3

5 years ago
Gah, bnicholson pointed out that I did a bad job un-bitrotting this:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c06a5b6a9f9f

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/074bf9222e0a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
You need to log in before you can comment on or make changes to this bug.