Closed Bug 853590 Opened 9 years ago Closed 9 years ago

Remove cprGet/ReleaseMutex from Signaling Code

Categories

(Core :: WebRTC: Signaling, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: ehugg, Assigned: ctangirala)

Details

(Whiteboard: [WebRTC][blocking-webrtc-][qa-])

Attachments

(1 file, 4 obsolete files)

Signaling code still has instances of cprGet/ReleaseMutex in kpmlmap.c and is defined in cpr for all OS targets.  These functions should be removed entirely.  The instances in kpml can be either replaces with mozilla/Mutex or the kpml functions can be stubbed out since we don't currently support kpml.
Assigning to our new Cisco volunteer Charith Tangirala
Assignee: nobody → ctangira
This reads off as code cleanup, which would mean this doesn't block.
Whiteboard: [WebRTC][blocking-webrtc-]
Yes, this is code cleanup. Things should run exactly the same after this patch.
Attachment #731188 - Attachment is obsolete: true
Comment on attachment 731192 [details] [diff] [review]
Remove unused mutex impl from CPR

Review of attachment 731192 [details] [diff] [review]:
-----------------------------------------------------------------

Unless there's a reason to keep cprCreateMutex and cprDestroyMutex you should remove those as well.  Update with this patch applied, then do an 'hg qref' and another bzexport.  If it looks OK, then I'll run a Try for you.

::: media/webrtc/signaling/src/sipcc/cpr/win32/cpr_win_locks.c
@@ +72,3 @@
>      cprMutexPtr = (cpr_mutex_t *) cpr_malloc(sizeof(cpr_mutex_t));
>      if (cprMutexPtr != NULL) {
> +         Assign name if one was passed in

These changes look suspicious, did you mean to remove the comment chars?  I'm guessing you meant to remove these altogether.
Attachment #731192 - Attachment is obsolete: true
Pushed to try - https://tbpl.mozilla.org/?tree=Try&rev=25410da1cccf

If this builds green, I'll ask for review probably from Jesup.
Looks like from the try build that we missed a reference to cprCreateMutex in the windows builds.
A quick grep -r of the signaling tree shows cprGet/Release/DeleteMutex are gone but there are still many instances of cprCreateMutex
Attachment #731242 - Attachment is obsolete: true
Got this on my Linux box with this patch:

/home/ehugg/mozilla/mozilla-central/media/webrtc/signaling/src/sipcc/cpr/linux/cpr_linux_init.c:116:29: fatal error: cpr_linux_locks.h: No such file or directory
compilation terminated.

Please 'grep -r cpr_linux_locks.h' the signaling directory for each file you removed to find any more.
Attachment #732011 - Attachment is obsolete: true
Comment on attachment 732097 [details] [diff] [review]
Remove unused mutex impl from CPR


Try run is green.  Requesting review from Randell Jesup
Attachment #732097 - Flags: review?(rjesup)
Attachment #732097 - Flags: review?(rjesup) → review+
https://hg.mozilla.org/mozilla-central/rev/5ec9994badfc
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Whiteboard: [WebRTC][blocking-webrtc-] → [WebRTC][blocking-webrtc-][qa-]
You need to log in before you can comment on or make changes to this bug.