853591 - Mozharness should be able to download the minidump_stackwalk binary from build/tools

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.0 - install minidump_stackwalk

Possibly ways to do this better, but should be good enough for my current needs. Did a push to ash-mozharness:
http://hg.mozilla.org/users/asasaki_mozilla.com/ash-mozharness/rev/4eca34e1a773

Watching:
https://tbpl.mozilla.org/?tree=Ash&showall=1&rev=e0464aa637bf

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 727896 [details] [diff] [review]
Patch 1.0 - install minidump_stackwalk

>diff --git a/configs/b2g/emulator_automation_config.py b/configs/b2g/emulator_automation_config.py
>--- a/configs/b2g/emulator_automation_config.py
>+++ b/configs/b2g/emulator_automation_config.py
>@@ -1,14 +1,20 @@
> # This is a template config file for b2g emulator unittest production.
>+import platform
>+if platform.architecture()[0] = "64bit"

I think you want == here, not = .

>+        os.environ['MINIDUMP_STACKWALK'] = os.path.join(dirs['abs_work_dir'], 'minidump_stackwalk')

This might be better in self.config['env'], but I'm ok with it here as well.

I think you do have to fix the s,=,==,, though.

Comment 3

[Andrew Halberstadt [:ahal]]

Attachment: Patch 2.0 - download from build/tools

Because of ted's comment (https://bugzilla.mozilla.org/show_bug.cgi?id=853544#c3) I decided to make the script download minidump_stackwalk from build/tools. I guess this means you can also remove the binaries from tooltool again if you want. Sorry about all the extra work! 

This patch is tested on ash-mozharness and appears to be working.

Comment 4

[Aki Sasaki (not active)]

Comment on attachment 728340 [details] [diff] [review]
Patch 2.0 - download from build/tools

I would lean towards putting this in TestingMixin rather than create a new mixin.
Glad you were able to get this to work!

Comment 5

[Andrew Halberstadt [:ahal]]

Moved it into TestingMixin (and tested that it works on ash) and pushed:
https://hg.mozilla.org/build/mozharness/rev/6a08cfda0350