853635 - Per-platform views are broken

Status: RESOLVED FIXED

(Tree Management Graveyard :: OrangeFactor, defect)

Description

[Mark Côté [:mcote]]

If you choose a platform from the filter drop-down, nearly all show an OF of 0, e.g. http://brasstacks.mozilla.com/orangefactor/?display=OrangeFactor&plat=osx&test=All&type=All&startday=2013-03-14&endday=2013-03-21&tree=trunk

Looks like a lot of platform names as stored in ES have changed, e.g. windows7-32, osx-10-6, android-4-0, android-2-2-armv6, etc...

Comment 1

[Mark Côté [:mcote]]

These are all the new platforms I've identified:

android-2-2, android-2-2-armv6, android-2-2-noion, android-4-0, b2g-arm-vm, linux32, osx-10-6, osx-10-7, osx-10-8, ubuntu32, ubuntu64, windows7-32,
windows8-32

It would seem that of the platforms defined in woo.utils.js, these do not exist anymore, or at least do not have any oranges filed against them:

osx, osx-64, windows7-64, android, android-xul

I guess windows7-64 is still supported but never run. osx has been replaced by version-specific platform names, as has android, but I'm not sure about osx-64.

Comment 2

[Phil Ringnalda (:philor)]

osx and osx-64 are probably from the days when what we had was 10.4 or 10.5 running the 32-bit half of the universal build and 10.6 or 10.7 running the 64-bit half. Now nothing runs the 32-bit half (as of the death of esr10) and three different versions run the 64-bit half.

We still do (hidden) Win64 builds, but there are no test slaves for it, so no current chance of it being tested, unless you see make check failures on the builds, which happen pretty much every run, but never get starred.

Comment 3

[Mark Côté [:mcote]]

So for completeness, the full list of platforms we can expect to see is

android-2-2, android-2-2-armv6, android-2-2-noion, android-4-0, b2g-arm-vm, linux, linux32, linux64, osx-10-6, osx-10-7, osx-10-8, ubuntu32, ubuntu64, windows, windowsxp, windows7-32, windows8-32

Wonder how we should coalesce platforms on OrangeFactor.  It is probably more useful to group some of those together with regards to filtering or tallying by category than to have each one listed explicitly.  It might be even better to allow grouping or individual platforms as the user desires, but that'll require more time and a better UI.

Also, I don't know the difference between linux and linux32/64 (I assume those are fedora, as contrasted by ubuntu32/64), nor between windows and the other version/arch-specific windows platforms.

Comment 4

[Jonathan Griffin (:jgriffin)]

(In reply to Mark Côté ( :mcote ) from comment #3)
> So for completeness, the full list of platforms we can expect to see is
> 
> android-2-2, android-2-2-armv6, android-2-2-noion, android-4-0, b2g-arm-vm,
> linux, linux32, linux64, osx-10-6, osx-10-7, osx-10-8, ubuntu32, ubuntu64,
> windows, windowsxp, windows7-32, windows8-32

You can exclude 'windows' and 'linux'; they don't occur in modern data.  (IIRC, linux used to mean linux32(fedora) and windows used to mean windows7-32.)

> Wonder how we should coalesce platforms on OrangeFactor.  It is probably
> more useful to group some of those together with regards to filtering or
> tallying by category than to have each one listed explicitly.  It might be
> even better to allow grouping or individual platforms as the user desires,
> but that'll require more time and a better UI.
> 
I don't know which is more useful, maybe just OS X/Windows/Fedora/Ubuntu/B2G/Android groups?

Comment 5

[Mark Côté [:mcote]]

Attachment: Group platforms when filtering/counting by category

Okay, I decided to group the various platforms together under Android, B2G, Linux, OS X, and Windows.  If we want finer-grained combinations, I can do that later.

I also did some cleanups to logic and data structures while I was at it.

Comment 6

[Mark Côté [:mcote]]

Attachment: Group platforms when filtering/counting by category

Little cross-browser fix, since String.startsWith() is apparently not widely supported.

Comment 7

[Ed Morley [:emorley]]

Comment on attachment 730382 [details] [diff] [review]
Group platforms when filtering/counting by category

I started looking at this today, but didn't manage to make it all the way through.

Initial thoughts:
* Having groups of platforms is great - I like the idea; however, I think there are times when we still need to keep separate - eg: fedora{32,64} == real hardware, whereas ubuntu{32,64} == VMs, and we've always had concerns over intermittent failure rate in VMs. Same for B2G in the emulator vs B2G in the emulator being run in a VM. Not sure of the best way to handle all of our use cases.
* The platform names themselves are provided by the TBPL _UI_ (legacy TBPL yuck!), so see this list for reference (there are a few missing):
https://hg.mozilla.org/webtools/tbpl/file/e843ce657f7d/js/Data.js#l480

Comment 8

[Ed Morley [:emorley]]

(In reply to Ed Morley (Away 29th-1st, UK public holiday) [:edmorley UTC+0] from comment #7)
> * The platform names themselves are provided by the TBPL _UI_ (legacy TBPL
> yuck!), so see this list for reference (there are a few missing):
> https://hg.mozilla.org/webtools/tbpl/file/e843ce657f7d/js/Data.js#l480

Actually, this is a more readable list of the same:
https://hg.mozilla.org/webtools/tbpl/file/e843ce657f7d/js/Config.js#l330

Comment 9

[Ed Morley [:emorley]]

Comment on attachment 730382 [details] [diff] [review]
Group platforms when filtering/counting by category

(Forgot to cancel when I made comment 7)

Comment 10

[Mark Côté [:mcote]]

Attachment: Group platforms when filtering/counting by category, v2

Okay, I have changed the grouping a bit.  There's now Fedora, Ubuntu (VM), OS X, Windows, Android, B2G, and B2G (VM).  Does that work for you?

One open question is whether we want this grouping when viewing orange occurrences on the Bug Details page.  I'm thinking no--there's probably greater value in knowing the specific platform.  Do you agree?  If so, do you think we should do "pretty names" ("Android 2.2", "Android 2.2 (no ion)", ...) or just the raw OS strings ("android-2.2", "android-2.2-noion", ...)?

Comment 11

[Mark Côté [:mcote]]

Hm I am going to answer my own question and say "yes" to having individual, pretty names for the bug details page.  New patch forthcoming.

Comment 12

[Mark Côté [:mcote]]

Attachment: Group platforms when filtering/counting by category, v3

This uses platform groups when filtering on the Orange Factor view or when counting by platform on the Bug Count view but displays the specific platform on the Bug Details view.  We could add the group name to the Bug Details view as well, in parentheses or something, but I'm not sure that would improve anything.

Also simplified and clarified a bit of code.

Comment 13

[Ed Morley [:emorley]]

Comment on attachment 733178 [details] [diff] [review]
Group platforms when filtering/counting by category, v3

Thank you, this looks great (and agree on comment 11).

These weren't added by your patch, but could you sort these out whilst your there? :-)

handlers.py:208: local variable 'tbplinfo' is assigned to but never used
handlers.py:696: local variable 'eslib' is assigned to but never used
handlers.py:697: local variable 'esbugs' is assigned to but never used

Comment 14

[Mark Côté [:mcote]]

http://hg.mozilla.org/automation/orangefactor/rev/5f34f314fb73

I'll do a separate bug for cleanups--there are even more in the JS. :)

Comment 15

[Mark Côté [:mcote]]

Tacked on a tiny fix for the branch control.

http://hg.mozilla.org/automation/orangefactor/rev/db5aad0c9d25