853687 - Add GA Tracking For Downloading Creative Brief

Status: VERIFIED FIXED

(Websites :: Firefox Flicks, defect)

Description

[Ben (:bensternthal)]

Add GA tracking for downloading:

http://static.mozilla.com/firefoxflicks/pdf/Filmmakers_Creative_Brief_en-US.pdf

Note we are trying to get logs/stats from static.mozilla.org see Bug #852628 but that might not be possible.

Comment 1

[Ben (:bensternthal)]

Adding #852628 as a blocker. We should only implement this if we cant get stats.

Using GA to do this requires inline script to be allowed via csp.

Comment 2

[Osmose [:osmose, :mkelly]]

(In reply to Ben (:bensternthal) from comment #1)
> Using GA to do this requires inline script to be allowed via csp.

Really? Why? I thought we had already determined that the only thing affected by putting GA inline vs external is the time between the page load and when GA kicks in which _might_ miss fast clicks.

Comment 3

[Ben (:bensternthal)]

So to track downloads we need to add an onclick handler as described here:

https://developers.google.com/analytics/devguides/collection/gajs/eventTrackerGuide#Anatomy

However reading the above, it should be possible for me to put the onclick handler in a sep JS file, I just need to be sure that GA is loaded first.

Comment 4

[Osmose [:osmose, :mkelly]]

(In reply to Ben (:bensternthal) from comment #3)
> However reading the above, it should be possible for me to put the onclick
> handler in a sep JS file, I just need to be sure that GA is loaded first.

Sounds right, only thing to add is that you don't actually have to wait until GA is completely loaded, just until the _gaq array exists (which might be what you meant), so just using a JS file listed below ga.js should do fine.

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/firefox-flicks

https://github.com/mozilla/firefox-flicks/commit/284794293b455499b1327fa30ca9cd55a26482ae
Fix Bug 853687 Add GA Click Tracking To Creative Brief DL

pull request fixes

Comment 6

[Ben (:bensternthal)]

Checked GA and we are receiving data from the click event.

All is well.

Comment 7

[Rebecca Billings [:rbillings]]

Closed as QA-