853704 - ECMA-402 tests ch10/10.1/10.1.1_13.js, ch10/10.1/10.1.1_19_c.js failing

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Norbert Lindenberg]

Tests ch10/10.1/10.1.1_13.js and ch10/10.1/10.1.1_19_c.js of the conformance test suite for standard ECMA-402, ECMAScript Internationalization API, fail when run against the implementation currently being landed.

The Intl.Collator options property "numeric" is not recognized.

The failure occurs because a table in the implementation is not cloned correctly due to bug 822080.

Comment 1

[Norbert Lindenberg]

Attachment: Enable the tests, which now pass

I'm not sure which change made these tests pass, but they do now. Let's enable them to prevent regressions.

Try run:
https://tbpl.mozilla.org/?tree=Try&rev=ad0900594df9

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 818239 [details] [diff] [review]
Enable the tests, which now pass

Review of attachment 818239 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, this would have changed with bug 919872, which "unrolled" step 13 in InitializeCollator.  Nicely caught, will push this tomorrow morning.

Comment 3

[Jeff Walden [:Waldo]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/87cdbcf08c84

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/87cdbcf08c84