Closed
Bug 853704
Opened 12 years ago
Closed 11 years ago
ECMA-402 tests ch10/10.1/10.1.1_13.js, ch10/10.1/10.1.1_19_c.js failing
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: mozillabugs, Assigned: mozillabugs)
References
()
Details
Attachments
(1 file)
1.38 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
Tests ch10/10.1/10.1.1_13.js and ch10/10.1/10.1.1_19_c.js of the conformance test suite for standard ECMA-402, ECMAScript Internationalization API, fail when run against the implementation currently being landed.
The Intl.Collator options property "numeric" is not recognized.
The failure occurs because a table in the implementation is not cloned correctly due to bug 822080.
Assignee | ||
Comment 1•11 years ago
|
||
I'm not sure which change made these tests pass, but they do now. Let's enable them to prevent regressions.
Try run:
https://tbpl.mozilla.org/?tree=Try&rev=ad0900594df9
Assignee: general → mozillabugs
Status: NEW → ASSIGNED
Attachment #818239 -
Flags: review?(jwalden+bmo)
Comment 2•11 years ago
|
||
Comment on attachment 818239 [details] [diff] [review]
Enable the tests, which now pass
Review of attachment 818239 [details] [diff] [review]:
-----------------------------------------------------------------
Ah, this would have changed with bug 919872, which "unrolled" step 13 in InitializeCollator. Nicely caught, will push this tomorrow morning.
Attachment #818239 -
Flags: review?(jwalden+bmo) → review+
Comment 3•11 years ago
|
||
Target Milestone: --- → mozilla27
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•