853720 - After bug 827446, SeaMonkey doesn't know mozcrash.

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Edmund Wong (:ewong)]

Bug 827446 introduced mozcrash module; but, SM's alive Tests can't find mozcrash

 _=/tools/python/bin/python
 using PTY: False
Traceback (most recent call last):
  File "leaktest.py", line 10, in <module>
    from automation import Automation
  File "/builds/slave/c-cen-t-lnx-dbg/build/objdir/mozilla/build/automation.py", line 35, in <module>
    import mozcrash
ImportError: No module named mozcrash
program finished with exit code 1

And TB tries to use checkForCrashes which was removed from automationutils.py 
in the aforementioned bug's patch. :

EBUG: child environment: {'LANG': 'en_US.UTF-8', 'TERM': 'vt100', 'SHELL': '/bin/bash', 'TZ': 'EST5EDT', 'HOSTNAME': 'mock', 'HOME': '/builds', 'PATH': '/usr/bin:/bin:/usr/sbin:/sbin', 'TMPDIR': '/tmp'}
/builds/slave/tb-c-cen-l64-d-000000000000000/build/objdir-tb/mozilla/_virtualenv/bin/python -u /builds/slave/tb-c-cen-l64-d-000000000000000/build/mozilla/config/pythonpath.py \
	  -I./mozilla/dist/../build -I/builds/slave/tb-c-cen-l64-d-000000000000000/build/mozilla/build \
	  /builds/slave/tb-c-cen-l64-d-000000000000000/build/mailnews/test/performance/bloat/runtest.py \
	    --distdir=./mozilla/dist --bin=thunderbird --brand=DailyDebug \
	    --symbols-path=./mozilla/dist/crashreporter-symbols 
Traceback (most recent call last):
  File "/builds/slave/tb-c-cen-l64-d-000000000000000/build/mozilla/config/pythonpath.py", line 56, in <module>
    main(sys.argv[1:])
  File "/builds/slave/tb-c-cen-l64-d-000000000000000/build/mozilla/config/pythonpath.py", line 48, in main
    execfile(script, frozenglobals)
  File "/builds/slave/tb-c-cen-l64-d-000000000000000/build/mailnews/test/performance/bloat/runtest.py", line 18, in <module>
    from automationutils import checkForCrashes
ImportError: cannot import name checkForCrashes
make: *** [mailbloat] Error 1

Comment 1

[Shadowized]

this also breaks PGO builds(at least for me) when invoking profileserver.py

Comment 2

[Mark Banner (:standard8)]

(In reply to Shadowized from comment #1)
> this also breaks PGO builds(at least for me) when invoking profileserver.py

Please file a separate bug about that, this one is for c-c issues, and that is an m-c issue.

Comment 3

[Mark Banner (:standard8)]

I've just fixed Thunderbird's tests with this fix:

https://hg.mozilla.org/comm-central/rev/0e7c3144903e

as a bustage fix which is a straight port of the changes in bug 827446.


I'm pretty sure SeaMonkey's builders need to be updated for this patch:

http://hg.mozilla.org/build/buildbotcustom/rev/b3ba4d217f62

Comment 4

[Edmund Wong (:ewong)]

Attachment: Unpack the mozbase* as well. (v1)

Comment 5

[Justin Wood (:Callek)]

Comment on attachment 728586 [details] [diff] [review]
Unpack the mozbase* as well. (v1)

...O a buildbot change!?

I suspect this won't be all that we need, but land it and lets do it :-)

Comment 6

[Edmund Wong (:ewong)]

Pushed to buildbotcustom:
http://hg.mozilla.org/build/buildbotcustom/rev/5b4696f6fc5a

Comment 7

[Edmund Wong (:ewong)]

Attachment: Buildbot config changes to use mozcrash. (v1)

Comment 8

[Edmund Wong (:ewong)]

Attachment: Buildbotcustom changes to enable mozcrash. (v1)

Comment 9

[Justin Wood (:Callek)]

Comment on attachment 730568 [details] [diff] [review]
Buildbotcustom changes to enable mozcrash. (v1)

Review of attachment 730568 [details] [diff] [review]:
-----------------------------------------------------------------

::: misc.py
@@ +1680,5 @@
>                   signingServers=secrets.get(pf.get('nightly_signing_servers')),
>                   tooltool_manifest_src=pf.get('tooltool_manifest_src', None),
>                   tooltool_url_list=config.get('tooltool_url_list', []),
>                   enable_pymake=enable_pymake,
> +                 runMakeAliveTests=config.get('run_make_alive_tests'),

please rip out this one (even moco doesn't do it for XULRunner)

@@ +2817,5 @@
>                  mochichrome_leak_threshold=mochichromeLeakThreshold,
>                  mochibrowser_leak_threshold=mochibrowserLeakThreshold,
>                  branchName=name,
>                  enable_pymake=enable_pymake,
> +                runMakeAliveTests=config['run_make_alive_tests'],

here too

@@ +2952,5 @@
>                   signingServers=secrets.get(pf.get('nightly_signing_servers')),
>                   tooltool_manifest_src= pf.get('tooltool_manifest_src', None),
>                   tooltool_url_list= config.get('tooltool_url_list', []),
>                   enable_pymake=enable_pymake,
> +                 runMakeAliveTests=config.get('run_make_alive_tests'),

here too

::: process/factory.py
@@ +407,5 @@
>          self.signingServers = signingServers
>          self.enableSigning = enableSigning
>          self.env = env.copy()
>          self.enable_pymake = enable_pymake
> +        self.runMakeAliveTests = runMakeAliveTests

nope not this...

@@ +833,5 @@
>          self.tooltool_manifest_src = tooltool_manifest_src
>          self.tooltool_url_list = tooltool_url_list or []
>          self.tooltool_script = tooltool_script
>          self.tooltool_bootstrap = tooltool_bootstrap
> +        self.runMakeAliveTests = runMakeAliveTests

...what you likely meant to do above was make this class add runMakeAliveTests to the __init__ kwargs,
class MercurialBuildFactory(MozillaBuildFactory):

ala http://mxr.mozilla.org/build/source/buildbotcustom/process/factory.py#807

@@ +1292,3 @@
>                      ))
>  
>      def addLeakTestStepsCommon(self, baseUrl, leakEnv, graphAndUpload):

Not quite here...

you need to change addLeakTestSteps as well in all places its defined (c.f. http://mxr.mozilla.org/build/source/buildbotcustom/process/factory.py#1637)

... then this func needs different code. ala: http://mxr.mozilla.org/build/source/buildbotcustom/process/factory.py#1446

the register/etc. happens in different dirs.

Comment 10

[Edmund Wong (:ewong)]

Attachment: Buildbotcustom changes for mozcrash. (v2)

Comment 11

[Edmund Wong (:ewong)]

Attachment: Buildbot config changes to use mozcrash. (v2)

Comment 12

[Edmund Wong (:ewong)]

Attachment: Buildbot config changes to use mozcrash. (v3)

Comment 13

[Edmund Wong (:ewong)]

Attachment: Buildbotcustom changes to use mozcrash. (v3)

Comment 14

[Jens Hatlak (:InvisibleSmiley)]

I just came here after trying to fulfill a request made in bug 900514 to run some suite Download Manager tests locally, which also failed with "No module named mozcrash". AFAICS the patches here aim at fixing buildbot. Please make sure that once that is done you either leave this bug open for the rest of file a follow-up.

Comment 15

[Frank Wein [:mcsmurf]]

Jens: I think currently there is no way no run tests anymore on comm-central :/ it looks like they broke everything like one or two weeks ago. Before that you could still do this:
TEST_PATH=suite/common/tests/browser/ pymake mochitest-browser-chrome
OR
cd to objdir/mozilla/_tests/testing/mochitest
../../../_virtualenv/Scripts/python.exe runtests.py --test-path=suite/common/tests/browser/
(running the python.exe from virtualenv works around the mozcrash issue, this is what pymake does basically in this case, running that python version)

Comment 16

[Frank Wein [:mcsmurf]]

Just for reference, I filed Bug 907434 on the tests issue.

Comment 17

[Edmund Wong (:ewong)]

This bug blocks the c-b tests, but not the actual release.

Comment 18

[Edmund Wong (:ewong)]

Comment on attachment 732639 [details] [diff] [review]
Buildbot config changes to use mozcrash. (v3)

No longer relevant.

Comment 19

[Edmund Wong (:ewong)]

Comment on attachment 732745 [details] [diff] [review]
Buildbotcustom changes to use mozcrash. (v3)

No longer relevant

Comment 20

[Edmund Wong (:ewong)]

The issue with this is basically mozbase/* are unpacked in the build
directory along with the tests, bin, modules directories.  However,
mochitests/runtests.py doesn't find mozcrash (et.al) from mozbase/ as they're
not in the pythonpath.

This will be fixed when bug 840427 is fixed.

Comment 21

[Edmund Wong (:ewong)]

Closing this bug.

This bug is probably now irrelevant as tests are now packed differently.