Closed Bug 853720 Opened 7 years ago Closed 3 years ago

After bug 827446, SeaMonkey doesn't know mozcrash.

Categories

(SeaMonkey :: Build Config, defect)

x86
All
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ewong, Assigned: ewong)

References

Details

(Whiteboard: [mozbase])

Attachments

(1 file, 6 obsolete files)

Bug 827446 introduced mozcrash module; but, SM's alive Tests can't find mozcrash

 _=/tools/python/bin/python
 using PTY: False
Traceback (most recent call last):
  File "leaktest.py", line 10, in <module>
    from automation import Automation
  File "/builds/slave/c-cen-t-lnx-dbg/build/objdir/mozilla/build/automation.py", line 35, in <module>
    import mozcrash
ImportError: No module named mozcrash
program finished with exit code 1

And TB tries to use checkForCrashes which was removed from automationutils.py 
in the aforementioned bug's patch. :

EBUG: child environment: {'LANG': 'en_US.UTF-8', 'TERM': 'vt100', 'SHELL': '/bin/bash', 'TZ': 'EST5EDT', 'HOSTNAME': 'mock', 'HOME': '/builds', 'PATH': '/usr/bin:/bin:/usr/sbin:/sbin', 'TMPDIR': '/tmp'}
/builds/slave/tb-c-cen-l64-d-000000000000000/build/objdir-tb/mozilla/_virtualenv/bin/python -u /builds/slave/tb-c-cen-l64-d-000000000000000/build/mozilla/config/pythonpath.py \
	  -I./mozilla/dist/../build -I/builds/slave/tb-c-cen-l64-d-000000000000000/build/mozilla/build \
	  /builds/slave/tb-c-cen-l64-d-000000000000000/build/mailnews/test/performance/bloat/runtest.py \
	    --distdir=./mozilla/dist --bin=thunderbird --brand=DailyDebug \
	    --symbols-path=./mozilla/dist/crashreporter-symbols 
Traceback (most recent call last):
  File "/builds/slave/tb-c-cen-l64-d-000000000000000/build/mozilla/config/pythonpath.py", line 56, in <module>
    main(sys.argv[1:])
  File "/builds/slave/tb-c-cen-l64-d-000000000000000/build/mozilla/config/pythonpath.py", line 48, in main
    execfile(script, frozenglobals)
  File "/builds/slave/tb-c-cen-l64-d-000000000000000/build/mailnews/test/performance/bloat/runtest.py", line 18, in <module>
    from automationutils import checkForCrashes
ImportError: cannot import name checkForCrashes
make: *** [mailbloat] Error 1
Summary: After bug 827446, SeaMonkey and TB's usage of checkForCrashes from Automationutils.py is broken. → After bug 827446, SeaMonkey doesn't know mozcrash and TB's usage of checkForCrashes from Automationutils.py is broken.
OS: Linux → All
Blocks: 827446
this also breaks PGO builds(at least for me) when invoking profileserver.py
(In reply to Shadowized from comment #1)
> this also breaks PGO builds(at least for me) when invoking profileserver.py

Please file a separate bug about that, this one is for c-c issues, and that is an m-c issue.
I've just fixed Thunderbird's tests with this fix:

https://hg.mozilla.org/comm-central/rev/0e7c3144903e

as a bustage fix which is a straight port of the changes in bug 827446.


I'm pretty sure SeaMonkey's builders need to be updated for this patch:

http://hg.mozilla.org/build/buildbotcustom/rev/b3ba4d217f62
Whiteboard: [mozcrash]
Whiteboard: [mozcrash] → [mozbase]
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #728586 - Flags: review?(bugspam.Callek)
Comment on attachment 728586 [details] [diff] [review]
Unpack the mozbase* as well. (v1)

...O a buildbot change!?

I suspect this won't be all that we need, but land it and lets do it :-)
Attachment #728586 - Flags: review?(bugspam.Callek) → review+
Summary: After bug 827446, SeaMonkey doesn't know mozcrash and TB's usage of checkForCrashes from Automationutils.py is broken. → After bug 827446, SeaMonkey doesn't know mozcrash.
Attachment #730567 - Flags: review?(bugspam.Callek)
Attachment #730568 - Flags: review?(bugspam.Callek)
Product: MailNews Core → SeaMonkey
Comment on attachment 730568 [details] [diff] [review]
Buildbotcustom changes to enable mozcrash. (v1)

Review of attachment 730568 [details] [diff] [review]:
-----------------------------------------------------------------

::: misc.py
@@ +1680,5 @@
>                   signingServers=secrets.get(pf.get('nightly_signing_servers')),
>                   tooltool_manifest_src=pf.get('tooltool_manifest_src', None),
>                   tooltool_url_list=config.get('tooltool_url_list', []),
>                   enable_pymake=enable_pymake,
> +                 runMakeAliveTests=config.get('run_make_alive_tests'),

please rip out this one (even moco doesn't do it for XULRunner)

@@ +2817,5 @@
>                  mochichrome_leak_threshold=mochichromeLeakThreshold,
>                  mochibrowser_leak_threshold=mochibrowserLeakThreshold,
>                  branchName=name,
>                  enable_pymake=enable_pymake,
> +                runMakeAliveTests=config['run_make_alive_tests'],

here too

@@ +2952,5 @@
>                   signingServers=secrets.get(pf.get('nightly_signing_servers')),
>                   tooltool_manifest_src= pf.get('tooltool_manifest_src', None),
>                   tooltool_url_list= config.get('tooltool_url_list', []),
>                   enable_pymake=enable_pymake,
> +                 runMakeAliveTests=config.get('run_make_alive_tests'),

here too

::: process/factory.py
@@ +407,5 @@
>          self.signingServers = signingServers
>          self.enableSigning = enableSigning
>          self.env = env.copy()
>          self.enable_pymake = enable_pymake
> +        self.runMakeAliveTests = runMakeAliveTests

nope not this...

@@ +833,5 @@
>          self.tooltool_manifest_src = tooltool_manifest_src
>          self.tooltool_url_list = tooltool_url_list or []
>          self.tooltool_script = tooltool_script
>          self.tooltool_bootstrap = tooltool_bootstrap
> +        self.runMakeAliveTests = runMakeAliveTests

...what you likely meant to do above was make this class add runMakeAliveTests to the __init__ kwargs,
class MercurialBuildFactory(MozillaBuildFactory):

ala http://mxr.mozilla.org/build/source/buildbotcustom/process/factory.py#807

@@ +1292,3 @@
>                      ))
>  
>      def addLeakTestStepsCommon(self, baseUrl, leakEnv, graphAndUpload):

Not quite here...

you need to change addLeakTestSteps as well in all places its defined (c.f. http://mxr.mozilla.org/build/source/buildbotcustom/process/factory.py#1637)

... then this func needs different code. ala: http://mxr.mozilla.org/build/source/buildbotcustom/process/factory.py#1446

the register/etc. happens in different dirs.
Attachment #730568 - Flags: review?(bugspam.Callek) → review-
Attachment #730568 - Attachment is obsolete: true
Attachment #731452 - Flags: review?(bugspam.Callek)
Attachment #732638 - Flags: review?(bugspam.Callek)
Attachment #730567 - Attachment is obsolete: true
Attachment #732638 - Attachment is obsolete: true
Attachment #730567 - Flags: review?(bugspam.Callek)
Attachment #732638 - Flags: review?(bugspam.Callek)
Attachment #732639 - Flags: review?(bugspam.Callek)
Attachment #731452 - Attachment is obsolete: true
Attachment #731452 - Flags: review?(bugspam.Callek)
Attachment #732745 - Flags: review?(bugspam.Callek)
I just came here after trying to fulfill a request made in bug 900514 to run some suite Download Manager tests locally, which also failed with "No module named mozcrash". AFAICS the patches here aim at fixing buildbot. Please make sure that once that is done you either leave this bug open for the rest of file a follow-up.
Jens: I think currently there is no way no run tests anymore on comm-central :/ it looks like they broke everything like one or two weeks ago. Before that you could still do this:
TEST_PATH=suite/common/tests/browser/ pymake mochitest-browser-chrome
OR
cd to objdir/mozilla/_tests/testing/mochitest
../../../_virtualenv/Scripts/python.exe runtests.py --test-path=suite/common/tests/browser/
(running the python.exe from virtualenv works around the mozcrash issue, this is what pymake does basically in this case, running that python version)
Just for reference, I filed Bug 907434 on the tests issue.
Blocks: 840427
This bug blocks the c-b tests, but not the actual release.
Comment on attachment 732639 [details] [diff] [review]
Buildbot config changes to use mozcrash. (v3)

No longer relevant.
Attachment #732639 - Flags: review?(bugspam.Callek)
Comment on attachment 732745 [details] [diff] [review]
Buildbotcustom changes to use mozcrash. (v3)

No longer relevant
Attachment #732745 - Attachment is obsolete: true
Attachment #732745 - Flags: review?(bugspam.Callek)
Attachment #732639 - Attachment is obsolete: true
The issue with this is basically mozbase/* are unpacked in the build
directory along with the tests, bin, modules directories.  However,
mochitests/runtests.py doesn't find mozcrash (et.al) from mozbase/ as they're
not in the pythonpath.

This will be fixed when bug 840427 is fixed.
Closing this bug.

This bug is probably now irrelevant as tests are now packed differently.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.