853782 - Notify receiving of WAP Push messages

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

After WAP Push message is received(and decoded if its' content type is supported), web/system apps need to be notified with message data.

several notifications need to be provided: system message, .addlistener() and .onreceive.

Comment 1

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0001. Set content type of decoded wap push message.

Comment 2

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0002. Notify receiving of WAP Push by System Message.

Comment 3

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0003. Fix runtime error due to no slice() function in emulator.

In emulator, stringTable.slice() doesn't exist. But it passed xpcshell test.
So get string data based on supported function.

Comment 4

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Test PDU : WBXML compressed SI

emulator command : sms pdu 00400191F10024001010000000005A0605040B8423F0010603AEAF8202056A28656D61696C2F3132332F6162632E776D6C00596F7520686176652034206E657720656D61696C730045C60D0378797A008583000AC3071999062515231510C304199906300183120101

Expected system message content :
message.contentType: text/vnd.wap.si
message.content: <si><indication href="http://www.xyz.com/email/123/abc.wml" created="1999-06-25T15:23:15Z" si-expires="1999-06-30T00:00:00Z">You have 4 new emails</indication></si>

Comment 5

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Test PDU : WBXML compressed SL

emulator command : sms pdu 00400191F10024001010000000001F0605040B8423F0010603B0AF8203066A086F7265696C6C7900850A83008501

Expected system message content :
message.contentType: text/vnd.wap.sl
message.content: <sl href="http://www.oreilly.com/"/>

Comment 6

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: Test code of receiving system message of WAP Push

Use sms app to receive WAP Push system message, and dump content to logcat.

Comment 7

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 762514 [details] [diff] [review]
0001. Set content type of decoded wap push message.

Review of attachment 762514 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/wappush/src/gonk/SiPduHelper.jsm
@@ +99,5 @@
>        }
>  
>        WBXML.PduHelper.parse(data, appToken, msg);
>  
> +      // Content is plain text now

Please remove this line.  Content-Type doesn't even exist before this patch.

::: dom/wappush/src/gonk/SlPduHelper.jsm
@@ +54,5 @@
>        }
>  
>        WBXML.PduHelper.parse(data, appToken, msg);
>  
> +      // Content is plain text now

Ditto.

Comment 8

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 762515 [details] [diff] [review]
0002. Notify receiving of WAP Push by System Message.

Review of attachment 762515 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/wappush/src/gonk/WapPushManager.js
@@ +95,3 @@
>      } else if (contentType === "text/vnd.wap.connectivity-xml" ||
>                 contentType === "application/vnd.wap.connectivity-wbxml") {
>        // TODO: Bug 869291 - Support Receiving WAP-Push-CP

Please remove this |else-if| block and move that TODO line into |else|.  Before bug 869291 is ready, CP is an unsupported type, isn't it?

@@ +96,5 @@
>                 contentType === "application/vnd.wap.connectivity-wbxml") {
>        // TODO: Bug 869291 - Support Receiving WAP-Push-CP
>      } else {
>        // Unsupported type, provide raw data.
>        msg.content = data.array;

Missing contentType for unsupported types.

Comment 9

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 762517 [details] [diff] [review]
0003. Fix runtime error due to no slice() function in emulator.

Review of attachment 762517 [details] [diff] [review]:
-----------------------------------------------------------------

Please correct the title.  There is nothing related to the emulator itself.  The reason you got a runtime error is because |data.array| is actually always a TypedArray.  And the reason we still have similar code in |WSP.Octet.decodeMultiple| is the lack of some code clean-up to remove them.

::: dom/wappush/src/gonk/WbxmlPduHelper.jsm
@@ +71,5 @@
> +  let rangeData;
> +  if (stringTable.subarray) {
> +    rangeData = stringTable.subarray(start, end);
> +  } else if (stringTable.slice) {
> +    rangeData = stringTable.slice(start, end);

You don't need all these tests and that unused |rangeData| variable.  |stringTable| here is always a TypedArray.

Comment 10

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0001. Set content type of wap push message. V2

Change function arguments to address comment 7 and comment 8

Comment 11

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0002. Notify receiving of WAP Push by System Message. V1.1

Update patch for comment 8 is addressed in part 1.

Comment 12

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0003. Support both TypedArray and Array in WBXML decoder. V1.1

PDU get from worker is TypedArray, while PDU from xpcshell test case is array.
So support both type until test cases are changed to use TypedArray.

Comment 13

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 763438 [details] [diff] [review]
0001. Set content type of wap push message. V2

Review of attachment 763438 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/wappush/src/gonk/WapPushManager.js
@@ +79,5 @@
>      *
>      * @see http://technical.openmobilealliance.org/tech/omna/omna-wsp-content-type.aspx
>      */
>      let contentType = options.headers["content-type"].media;
> +    let msg = {};

This line may soon overwritten when the message is of a supported type.  You may just declare a variable here.

  let msg;

@@ +96,1 @@
>        msg.content = data.array;

msg = {
  ...
};

Comment 14

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0001. Set content type of wap push message. V2.1

Address comment 13

Comment 15

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0003. Treat PDU data in correct type, Uint8Array

It requires modification in test case per part 0001, so also correct the type of data PDU.

Comment 17

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Try : https://tbpl.mozilla.org/?tree=Try&rev=672d3c639461

Comment 18

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/projects/birch/rev/183501e0a905
https://hg.mozilla.org/projects/birch/rev/5026554ec28f (differ from 763439, has to be rebased)
https://hg.mozilla.org/projects/birch/rev/68ce74382b35

Comment 19

[Ryan VanderMeulen (PTO, back July 27)]

https://hg.mozilla.org/mozilla-central/rev/183501e0a905
https://hg.mozilla.org/mozilla-central/rev/5026554ec28f
https://hg.mozilla.org/mozilla-central/rev/68ce74382b35