853814 - Make nsDocShell::mScriptGlobal an nsGlobalWindow

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 728160 [details] [diff] [review]
Patch v1

>@@ -9137,29 +9122,28 @@ nsDocShell::InternalLoad(nsIURI * aURI,
>             // Dispatch the popstate and hashchange events, as appropriate.

Shouldn't we be holding a strong ref to the window on the stack while we do that?

>                   // Make sure to use oldURI here, not mCurrentURI, because by

You changed the indent of the code, but no that comment.  Please fix?

r=me, though next time try to keep the whitespace changes separate from the substantive ones?

Comment 2

[:aceman]

+#include "mozilla/Telemetry.h"
+#include "mozilla/Telemetry.h"

?

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/8866eb3c3a30

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Sure, there's two of

-#include "mozilla/Telemetry.h"

too.