Closed
Bug 853814
Opened 12 years ago
Closed 12 years ago
Make nsDocShell::mScriptGlobal an nsGlobalWindow
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(1 file)
|
25.22 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #728160 -
Flags: review?(bzbarsky)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 728160 [details] [diff] [review]
Patch v1
>@@ -9137,29 +9122,28 @@ nsDocShell::InternalLoad(nsIURI * aURI,
> // Dispatch the popstate and hashchange events, as appropriate.
Shouldn't we be holding a strong ref to the window on the stack while we do that?
> // Make sure to use oldURI here, not mCurrentURI, because by
You changed the indent of the code, but no that comment. Please fix?
r=me, though next time try to keep the whitespace changes separate from the substantive ones?
Attachment #728160 -
Flags: review?(bzbarsky) → review+
|
Assignee | |
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
|
|
Assignee | |
Comment 4•12 years ago
|
||
Sure, there's two of
-#include "mozilla/Telemetry.h"
too.
You need to log in
before you can comment on or make changes to this bug.
Description
•